Address feedback

Author: st0012

lib/rdoc/markup/to_html_crossref.rb

@@ -228,12 +228,12 @@ def convert_flow(flow_items, &block)
   # When the candidate occupies the whole span (aside from trailing
   # punctuation), the tt markup is replaced by the resolved cross-reference.
 
-  def convert_tt_crossref(flow, index)
-    opener = flow[index]
+  def convert_tt_crossref(flow_items, index)
+    opener = flow_items[index]
     return unless tt_tag?(opener.turn_on)
 
-    string = flow[index + 1]
-    closer = flow[index + 2]
+    string = flow_items[index + 1]
+    closer = flow_items[index + 2]
 
     return unless String === string
     return unless RDoc::Markup::AttrChanger === closer

test/rdoc/rdoc_markup_to_html_crossref_test.rb

@@ -34,30 +34,21 @@ def test_convert_CROSSREF
   end
 
   def test_convert_CROSSREF_backslash_in_tt
-    hyperlink_all = @options.hyperlink_all
     @options.hyperlink_all = false
 
-    formatter = RDoc::Markup::ToHtmlCrossref.new @options, 'C9.html', @c9_b
-    result = formatter.convert '<tt>C1</tt>'
+    formatter = RDoc::Markup::ToHtmlCrossref.new(@options, 'C9.html', @c9_b)
 
+    result = formatter.convert '<tt>C1</tt>'
     assert_equal para('<a href="C1.html"><code>C1</code></a>'), result
 
-    formatter = RDoc::Markup::ToHtmlCrossref.new @options, 'C9.html', @c9_b
     result = formatter.convert '<tt>.bar.hello()</tt>'
-
     assert_equal para('<code>.bar.hello()</code>'), result
 
-    formatter = RDoc::Markup::ToHtmlCrossref.new @options, 'C9.html', @c9_b
     result = formatter.convert '<tt>.bar.hello(\)</tt>'
-
     assert_equal para('<code>.bar.hello(\)</code>'), result
 
-    formatter = RDoc::Markup::ToHtmlCrossref.new @options, 'C9.html', @c9_b
     result = formatter.convert '<tt>.bar.hello(\\\\)</tt>'
-
     assert_equal para('<code>.bar.hello(\\)</code>'), result
-  ensure
-    @options.hyperlink_all = hyperlink_all
   end
 
   def test_convert_CROSSREF_ignored_excluded_words