Style linked types with consistent underline

Author: st0012

lib/rdoc/generator/template/aliki/css/rdoc.css

@@ -1076,11 +1076,14 @@ main h6 a:hover {
 .rbs-builtin { color: var(--code-purple); }
 
 a.rbs-type {
-  text-decoration: none;
+  text-decoration: underline;
+  text-decoration-color: var(--color-border-default);
+  text-underline-offset: 0.2em;
+  transition: text-decoration-color var(--transition-fast);
 }
 
 a.rbs-type:hover {
-  text-decoration: underline;
+  text-decoration-color: currentColor;
 }
 
 /* Emphasis */

lib/rdoc/generator/template/aliki/js/rbs_highlighter.js

@@ -99,9 +99,12 @@
   }
 
   function initHighlighting() {
+    var elements = document.querySelectorAll('.method-type-signature code');
+    if (elements.length === 0) return;
+
     typeLookup = buildTypeLookup();
 
-    document.querySelectorAll('.method-type-signature code').forEach(function(el) {
+    elements.forEach(function(el) {
       if (el.getAttribute('data-highlighted') === 'true') return;
       el.innerHTML = highlightRbs(el.textContent); // eslint-disable-line no-unsanitized/property
       el.setAttribute('data-highlighted', 'true');

lib/rdoc/parser/prism_ruby.rb

@@ -486,7 +486,6 @@ def consecutive_comment(line_no)
 
   private def validate_type_signature(sig)
     sig.split("\n").each do |line|
-      # Method types contain ->, plain types (for attributes) don't
       error = if line.include?('->')
         RDoc::RbsSupport.validate_method_type(line)
       else

lib/rdoc/rbs_support.rb

@@ -74,14 +74,17 @@ def self.merge_into_store(store, signatures)
         next if method.type_signature
 
         key = method.singleton ? "#{cm.full_name}::#{method.name}" : "#{cm.full_name}##{method.name}"
-        method.type_signature = signatures[key] if signatures[key]
+        if (sig = signatures[key])
+          method.type_signature = sig
+        end
       end
 
       cm.attributes.each do |attr|
         next if attr.type_signature
 
-        key = "#{cm.full_name}.#{attr.name}"
-        attr.type_signature = signatures[key] if signatures[key]
+        if (sig = signatures["#{cm.full_name}.#{attr.name}"])
+          attr.type_signature = sig
+        end
       end
     end
   end