Refactor PR preview workflow for improved approval process#1370
Merged
Refactor PR preview workflow for improved approval process#1370
Conversation
Deploying rdoc with
|
| Latest commit: |
610ac87
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://297db41c.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://improve-preview-building-wor.rdoc-6cd.pages.dev |
st0012
force-pushed
the
improve-preview-building-workflows
branch
5 times, most recently
from
cad758f to
d2cb4c7
Compare
|
🚀 Preview deployment available at: https://52432c94.rdoc-6cd.pages.dev (commit: 610ac87) |
st0012
force-pushed
the
improve-preview-building-workflows
branch
from
d2cb4c7 to
2cca158
Compare
Because GitHub Actions' manual dispatching doesn't allow pre-filling the PR number, it'd be tedious for maintainers to manually trigger the workflow. This refactor introduces a new workflow that checks for PRs from the main repository or forks, and if it's a fork, it requires approval to deploy. This works by associating the workflow with an environment that requires approval to deploy. The pr-review-check.yml workflow will then call the cloudflare-preview.yml workflow to build and deploy the preview.
st0012
force-pushed
the
improve-preview-building-workflows
branch
from
2cca158 to
af6ac77
Compare
st0012
added a commit
that referenced
this pull request
Jun 27, 2025
After testing, #1370 doesn't work for forks as the `trigger-fork-preview` is run on the fork repo, not on the main repo, the secrets actually aren't available. So I'm changing the flows to the below: ### Main Repository PR Flow ```mermaid graph LR A[PR Opened<br/>from main repo] --> B[pr-preview-check.yml<br/>deploy-main-repo job] B --> C[Dispatch Event<br/>with GITHUB_TOKEN] C --> D[cloudflare-preview.yml<br/>receives dispatch] D --> E[Deploy with<br/>Repository Secrets] ``` ### Fork PR Flow ```mermaid graph LR A[PR Opened<br/>from fork] --> B[pr-preview-check.yml<br/>approve-fork job] B --> D[Manual Approval<br/>Required] D --> F[fork-preview-deploy.yml<br/>triggered by workflow_run and dispatches event] F --> G[cloudflare-preview.yml<br/>receives dispatch] G --> H[Deploy with<br/>Repository Secrets] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because GitHub Actions' manual dispatching doesn't allow pre-filling the PR number, it'd be tedious for maintainers to manually trigger the workflow.
This refactor introduces a new workflow that checks for PRs from the main repository or forks, and if it's a fork, it requires approval to deploy. This works by associating the workflow with an environment that requires approval to deploy.
The pr-review-check.yml workflow will then call the cloudflare-preview.yml workflow to build and deploy the preview.