Use repository_dispatch for previewing instead#1384
Merged
Conversation
Deploying rdoc with
|
| Latest commit: |
e2a5443
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8c9e5d8.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://improve-preview-building-wor.rdoc-6cd.pages.dev |
ca3e789 to
4850374
Compare
4850374 to
e2a5443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing, #1370 doesn't work for forks as the
trigger-fork-previewis run on the fork repo, not on the main repo, the secrets actually aren't available. So I'm changing the flows to the below:Main Repository PR Flow
graph LR A[PR Opened<br/>from main repo] --> B[pr-preview-check.yml<br/>deploy-main-repo job] B --> C[Dispatch Event<br/>with GITHUB_TOKEN] C --> D[cloudflare-preview.yml<br/>receives dispatch] D --> E[Deploy with<br/>Repository Secrets]Fork PR Flow
graph LR A[PR Opened<br/>from fork] --> B[pr-preview-check.yml<br/>approve-fork job] B --> D[Manual Approval<br/>Required] D --> F[fork-preview-deploy.yml<br/>triggered by workflow_run and dispatches event] F --> G[cloudflare-preview.yml<br/>receives dispatch] G --> H[Deploy with<br/>Repository Secrets]