Skip to content

Change error message assertion to make it pass in JRuby#1425

Merged
tompng merged 1 commit intoruby:masterfrom
tompng:jruby_ci_fix
Sep 16, 2025
Merged

Change error message assertion to make it pass in JRuby#1425
tompng merged 1 commit intoruby:masterfrom
tompng:jruby_ci_fix

Conversation

@tompng
Copy link
Copy Markdown
Member

@tompng tompng commented Sep 14, 2025 •
edited
Loading

Fix JRuby ci failure

Failure: test_check_files_warn(RDocOptionsTest)
/home/runner/work/rdoc/rdoc/test/rdoc/rdoc_options_test.rb:50:in 'test_check_files_warn'
     49:     assert_empty out
  => 50:     assert_equal "file 'nonexistent' not found\n", err
     51:     assert_empty @options.files
     52:   end
<"file 'nonexistent' not found\n"> expected but was
<"/home/runner/work/rdoc/rdoc/lib/rdoc/options.rb:1370: warning: file 'nonexistent' not found\n">

Related to ruby/prism#3647

@tompng tompng had a problem deploying to fork-preview-protection September 14, 2025 14:55 — with GitHub Actions Failure
@tompng tompng temporarily deployed to fork-preview-protection September 14, 2025 14:59 — with GitHub Actions Inactive
@matzbot
Copy link
Copy Markdown
Collaborator

matzbot commented Sep 14, 2025 •
edited
Loading

🚀 Preview deployment available at: https://bf504775.rdoc-6cd.pages.dev (commit: 4787bef)

kou
kou approved these changes Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread test/rdoc/rdoc_text_test.rb Outdated
end

assert_equal "mismatched <tt> tag\n", err
assert_include err, "mismatched <tt> tag\n"
Copy link
Copy Markdown
Member

@kou kou Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert_include err, "mismatched <tt> tag\n"
assert_include err, "mismatched <tt> tag\n"

@tompng tompng temporarily deployed to fork-preview-protection September 16, 2025 10:18 — with GitHub Actions Inactive
@tompng tompng merged commit 71d4090 into ruby:master Sep 16, 2025
33 checks passed
@tompng tompng deleted the jruby_ci_fix branch September 16, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@st0012 st0012 st0012 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tompng @matzbot @kou @st0012