Skip to content

[Aliki] Remove nav detail's nested padding-right#1455

Merged
tompng merged 1 commit intoruby:masterfrom
tompng:rm_nav_nested_right_padding
Nov 18, 2025
Merged

[Aliki] Remove nav detail's nested padding-right#1455
tompng merged 1 commit intoruby:masterfrom
tompng:rm_nav_nested_right_padding

Conversation

@tompng
Copy link
Copy Markdown
Member

@tompng tompng commented Nov 17, 2025

Before:
padding-right is nested.
Nested <details> have narrow width.
before_1
before_2
before_3

After:
after

@tompng tompng temporarily deployed to fork-preview-protection November 17, 2025 16:56 — with GitHub Actions Inactive
@matzbot
Copy link
Copy Markdown
Collaborator

matzbot commented Nov 17, 2025

🚀 Preview deployment available at: https://46c56c46.rdoc-6cd.pages.dev (commit: 9fd6b8f)

@@ -866,7 +866,6 @@ nav a:hover {

nav ul li details {
position: relative;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered that this may not be needed either when reviewing this 🤔

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tompng tompng force-pushed the rm_nav_nested_right_padding branch from 9fd6b8f to 69debc5 Compare November 18, 2025 11:36
@tompng tompng temporarily deployed to fork-preview-protection November 18, 2025 11:36 — with GitHub Actions Inactive
@tompng tompng merged commit b0e21ef into ruby:master Nov 18, 2025
32 of 33 checks passed
@tompng tompng deleted the rm_nav_nested_right_padding branch November 18, 2025 12:01
@st0012 st0012 changed the title Remove nav detail's nested padding-right [Aliki] Remove nav detail's nested padding-right Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants