[Aliki] Stable calculation of active toc#1456
Merged
tompng merged 2 commits intoruby:masterfrom Nov 18, 2025
Merged
Conversation
IntersectionObserver only notifies changed intersections. We need to track which heading tag currently intersects with viewport. Use the top-most intersecting heading to make user-clicked toc links match with active toc links.
tompng
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
Collaborator
|
🚀 Preview deployment available at: https://9a80f375.rdoc-6cd.pages.dev (commit: 5b079b8) |
kou
approved these changes
Nov 18, 2025
| return intersectingHeadings.has(heading); | ||
| }); | ||
| if (!firstIntersectingHeading) return; | ||
| var correspondingLink = document.querySelector('.toc-link[data-target="' + firstIntersectingHeading.id + '"]'); |
Member
There was a problem hiding this comment.
This may be simpler:
Suggested change
| var correspondingLink = document.querySelector('.toc-link[data-target="' + firstIntersectingHeading.id + '"]'); | |
| var correspondingLink = document.querySelector(`.toc-link[data-target="${firstIntersectingHeading.id}"]`); |
Member
Author
There was a problem hiding this comment.
I want to keep it for now.
Currently this file doesn't use ES6 feature: const let ()=>{} and `${}`
I think we can use newer syntaxes, but I think it's better to do it in a separate pull request.
Remove assignment to unused variable Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
tompng
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
tompng
added a commit
that referenced
this pull request
Nov 19, 2025
Use template literals, arrow functions, const, let. Add "use strict" to detect potential problem quickly. (Like this one: #1456 (comment))
st0012
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this unstable active table-of-contents link calculation shown in this video:
Clicking "Plugin types", active toc link will be "Option Parsing" or "File Parsing", depend on previous scroll position.
https://github.com/user-attachments/assets/bfd5c92a-9f11-4c9b-9267-86ae55607541
IntersectionObserver only notifies changed intersections.
We need to track which heading tag currently intersects with viewport. (I use Set in this pull request)
Use the top-most intersecting heading to make user-clicked toc links match with active toc links.