Fix rb_define_method(singleton_class_of_module, ...) not to change nested module name#1458
Merged
tompng merged 1 commit intoruby:masterfrom Nov 19, 2025
Merged
Conversation
fa630f0 to
2c33648
Compare
2c33648 to
c591a67
Compare
st0012
approved these changes
Nov 18, 2025
…sted module name Always track class and singleton class stored to a variable to `@classes`. Otherwise, `find_class var_name, class_name` called from `handle_method` will add a new class to `@toplevel`.
c591a67 to
58e0fd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1440
Always track class and singleton class stored to a variable to
@classes.Otherwise,
find_class var_name, class_namecalled fromhandle_methodwill add a new class.Before:


After:
Minimal reproduction:
RDoc::Parser::C#handle_methodcallsfind_class 'mBarS', 'Foo::Bar'.RDoc::Parser::C#find_classcalls@top_level.add_class RDoc::NormalClass, 'Foo::Bar'. This will create::Barfor some reason andFoo::Bardisappears from generated document.