Skip to content

Style method entries as signature cards in aliki theme #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
st0012 wants to merge 1 commit into
base: master
Choose a base branch
from
+45 −11
Open

Style method entries as signature cards in aliki theme #1669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 45 additions & 11 deletions lib/rdoc/generator/template/aliki/css/rdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@
--color-accent-subtle: var(--color-primary-50);
--color-code-bg: #f6f8fa;
--color-code-border: var(--color-neutral-300);
--color-sig-bg: var(--color-neutral-100);
--color-sig-border: var(--color-primary-200);
--color-nav-bg: #fff;
--color-nav-text: var(--color-neutral-700);
--color-th-background: var(--color-neutral-100);
Expand Down Expand Up @@ -203,6 +205,8 @@
--color-accent-subtle-hover: rgb(235 84 79 / 20%);
--color-code-bg: var(--color-neutral-800);
--color-code-border: var(--color-neutral-700);
--color-sig-bg: #211f1e; /* between neutral-900 and neutral-800 */
--color-sig-border: var(--color-accent-primary);
--color-nav-bg: var(--color-neutral-900);
--color-nav-text: var(--color-neutral-50);
--color-th-background: var(--color-background-tertiary);
Expand Down Expand Up @@ -1282,6 +1286,7 @@ main .method-description .method-calls-super {
}

main .method-detail {
position: relative;
margin-bottom: 2.5em;
}

Expand All @@ -1292,16 +1297,33 @@ main .method-detail:target {
}

main .method-header {
display: inline-block;
max-width: calc(100% - 6em); /* 6em is the width of the source code toggle */
background: var(--color-sig-bg);
border-left: 3px solid var(--color-sig-border);
border-radius: var(--radius-md);
padding: var(--space-3);
}

main .method-heading {
position: relative;
display: flex;
flex-direction: column;
align-items: flex-start;
font-family: var(--font-code);
font-size: var(--font-size-lg);
font-weight: var(--font-weight-semibold);
margin-bottom: var(--space-3);
line-height: var(--line-height-normal);
}

main .method-heading a {
color: inherit;
text-decoration: none;
}

main .method-heading a:hover {
color: var(--color-accent-primary);
}

main .method-heading .method-callseq {
display: block;
}

main .method-heading .method-name {
Expand All @@ -1313,7 +1335,9 @@ main .method-heading .method-args {
}

main .method-controls {
float: right;
position: absolute;
top: var(--space-3);
right: var(--space-3);
}
Comment on lines 1337 to 1341
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main .method-controls is now absolutely positioned, but .method-header/.method-heading no longer reserves horizontal space for it (the previous max-width: calc(100% - 6em) was removed). With long call sequences or method names, the signature text can render underneath the “Source” control.

Consider reserving space via padding-right on .method-header/.method-heading (or a grid/flex layout that allocates a dedicated column for .method-controls) so the signature and control cannot overlap.

Copilot uses AI. Check for mistakes.

main .method-controls summary {
Expand Down Expand Up @@ -1356,14 +1380,16 @@ main .method-controls summary:active {
border-color: var(--color-primary-500);
}

main .method-description,
main .aliases {
margin-top: 0.75em;
main .method-description {
margin-top: var(--space-5);
padding-left: var(--space-2);
color: var(--color-text-primary);
line-height: var(--line-height-relaxed);
}

Comment on lines +1384 to 1389
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector main .method-description applies to both method docs and attribute docs (attributes also render a .method-description block, but don’t have the new .method-header “signature card”). The new margin-top/padding-left intended to align with the signature card will therefore also shift attribute descriptions.

If the intent is to only style method descriptions, consider scoping the rule to method entries (e.g., target .method-description that follows a .method-header within the same .method-detail) so attribute descriptions keep their previous alignment.

Suggested change
margin-top: var(--space-5);
padding-left: var(--space-2);
color: var(--color-text-primary);
line-height: var(--line-height-relaxed);
}
color: var(--color-text-primary);
line-height: var(--line-height-relaxed);
}
main .method-detail .method-header + .method-description {
margin-top: var(--space-5);
padding-left: var(--space-2);
}

Copilot uses AI. Check for mistakes.
main .aliases {
padding-top: 4px;
margin-top: var(--space-4);
padding-top: var(--space-1);
font-style: italic;
cursor: default;
}
Expand Down Expand Up @@ -1410,9 +1436,17 @@ main .attribute-access-type {
white-space: nowrap;
}

main .method-heading {
font-size: var(--font-size-base);
}

main .method-header {
padding: var(--space-2);
}

main .method-controls {
margin-top: 10px;
float: none;
position: static;
margin-top: var(--space-2);
}
}

Expand Down