Skip to content

Add tsort to Gemfile to be able to run rbs#847

Closed
olleolleolle wants to merge 1 commit into
ruby:masterfrom
olleolleolle:add-tsort
Closed

Add tsort to Gemfile to be able to run rbs#847
olleolleolle wants to merge 1 commit into
ruby:masterfrom
olleolleolle:add-tsort

Conversation

@olleolleolle

@olleolleolle olleolleolle commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

This change makes rbs run green 🟢 by avoiding a warning message about missing tsort gem in newer Ruby versions, in output.

Upstream rbs gem has fixed this, but no release is currently published.

Fixes #845

@olleolleolle olleolleolle changed the title Add tsort to Gemfile Add tsort to Gemfile to be able to run some tests Aug 12, 2025
So that rbs can run right, before it has a new release.

Fixes ruby#845
@olleolleolle
olleolleolle requested review from st0012 and tompng August 12, 2025 12:28
@olleolleolle olleolleolle changed the title Add tsort to Gemfile to be able to run some tests Add tsort to Gemfile to be able to run rbs Aug 12, 2025
@st0012

st0012 commented Aug 12, 2025

Copy link
Copy Markdown
Member

Does it make sense to point rbs to GH source in irb's Gemfile instead?
If repl_type_completor works with it, it should solve the warning issue in both irb and here.

@olleolleolle

Copy link
Copy Markdown
Contributor Author

@st0012 Great idea, thanks for the nudge!

@olleolleolle

Copy link
Copy Markdown
Contributor Author

Closed in favor of ruby/irb#1117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

head CI tests fail on needing tsort, re Ruby 3.6.0

2 participants