Merge pull request #28 from ruby/rescue_const_path_fix

Fix rescue_node reference evaluation

Author: tompng

lib/repl_type_completor.rb

@@ -101,7 +101,7 @@ def analyze_code(code, binding = Object::TOPLEVEL_BINDING)
         [op == '::' ? :call_or_const : :call, name, receiver_type, self_call]
       when Prism::LocalVariableReadNode, Prism::LocalVariableTargetNode
         [:lvar_or_method, target_node.name.to_s, calculate_scope.call]
-      when Prism::ConstantPathNode
+      when Prism::ConstantPathNode, Prism::ConstantPathTargetNode
         name = target_node.name.to_s
         if target_node.parent # A::B
           receiver, scope = calculate_type_scope.call(target_node.parent)

lib/repl_type_completor/type_analyzer.rb

@@ -579,12 +579,7 @@ def evaluate_rescue_node(node, scope)
           end
           error_types << Types::InstanceType.new(StandardError) if error_types.empty?
           error_type = Types::UnionType[*error_types]
-          case node.reference
-          when Prism::LocalVariableTargetNode, Prism::InstanceVariableTargetNode, Prism::ClassVariableTargetNode, Prism::GlobalVariableTargetNode, Prism::ConstantTargetNode
-            s[node.reference.name.to_s] = error_type
-          when Prism::CallTargetNode, Prism::IndexTargetNode
-            evaluate_multi_write_receiver node.reference, s, nil
-          end
+          evaluate_write node.reference, error_type, s, nil
         end
         node.statements ? evaluate(node.statements, s) : Types::NIL
       end

test/repl_type_completor/test_type_analyze.rb

@@ -74,7 +74,11 @@ def test_rescue_assign
       assert_equal [:ivar, '@a'], analyze('begin; rescue => @a')[0, 2]
       assert_equal [:cvar, '@@a'], analyze('begin; rescue => @@a')[0, 2]
       assert_equal [:const, 'A'], analyze('begin; rescue => A')[0, 2]
+      assert_equal [:const, 'B'], analyze('begin; rescue => A::B')[0, 2]
       assert_equal [:call, 'b'], analyze('begin; rescue => a.b')[0, 2]
+      assert_call 'begin; rescue => (a=1)::B; a.', include: Integer
+      assert_call 'begin; rescue => A; A.', include: StandardError
+      assert_call 'begin; rescue => Array::A; Array::A.', include: StandardError
     end
 
     def test_ref