Skip to content

Fix slow completion on method chain of huge arrays and hashes (size >= 10000000) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tompng wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

Fix slow completion on method chain of huge arrays and hashes (size >= 10000000) #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/repl_type_completor/types.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,13 @@ def self.union_type_from_objects(objects)
UnionType[*class_instances.map { InstanceType.new _1, nil, _2 }, *modules.uniq.map { SingletonType.new _1 }]
end

def self.union_type_from_objects_list(objects_list)
objects = objects_list.flat_map do |objects|
objects.size < OBJECT_TO_TYPE_SAMPLE_SIZE ? objects : objects.sample(OBJECT_TO_TYPE_SAMPLE_SIZE)
end
union_type_from_objects(objects)
end

class SingletonType
attr_reader :module_or_class
def initialize(module_or_class)
Expand Down Expand Up @@ -268,11 +275,11 @@ def expand_params
return params unless @instances

if @klass == Array
type = Types.union_type_from_objects(@instances.flatten(1))
type = Types.union_type_from_objects_list(@instances)
{ Elem: UnionType[*params[:Elem], *type] }
elsif @klass == Hash
key = Types.union_type_from_objects(@instances.map(&:keys).flatten(1))
value = Types.union_type_from_objects(@instances.map(&:values).flatten(1))
key = Types.union_type_from_objects_list(@instances.map(&:keys))
value = Types.union_type_from_objects_list(@instances.map(&:values))
{
K: UnionType[*params[:K], key],
V: UnionType[*params[:V], value]
Expand Down
Loading