Rename InvalidFileNameError to InvalidWindowsFileNameError for clarity

Author: Saidbek

lib/rubygems/package.rb

@@ -92,7 +92,7 @@ class TarInvalidError < Error; end
   ##
   # Raised when a filename contains characters that are invalid on Windows
 
-  class InvalidFileNameError < Error
+  class InvalidWindowsFileNameError < Error
     def initialize(filename, gem_name = nil)
       message = "The gem contains a file '#{filename}' with characters in its name that are not allowed on Windows (e.g., colons)."
       message += " This is a problem with the '#{gem_name}' gem, not Rubygems." if gem_name
@@ -445,7 +445,7 @@ def extract_tar_gz(io, destination_dir, pattern = "*") # :nodoc:
 
         if invalid_windows_filename?(full_name)
           gem_name = @spec ? @spec.full_name : "unknown"
-          raise Gem::Package::InvalidFileNameError.new(full_name, gem_name)
+          raise Gem::Package::InvalidWindowsFileNameError.new(full_name, gem_name)
         end
 
         if entry.symlink?
@@ -480,9 +480,9 @@ def extract_tar_gz(io, destination_dir, pattern = "*") # :nodoc:
               out.flush
               out.chmod file_mode(entry.header.mode) & ~File.umask
             end
-          rescue Errno::EINVAL => e
+          rescue Errno::EINVAL
             gem_name = @spec ? @spec.full_name : "unknown"
-            raise Gem::Package::InvalidFileNameError.new(full_name, gem_name), e.message
+            raise Gem::Package::InvalidWindowsFileNameError.new(full_name, gem_name)
           end
         end
 

test/rubygems/test_gem_package.rb

@@ -1316,7 +1316,7 @@ def test_invalid_windows_filename
   end
 
   def test_invalid_file_name_error_message
-    error = Gem::Package::InvalidFileNameError.new("spec/internal/:memory", "crono-2.0.1")
+    error = Gem::Package::InvalidWindowsFileNameError.new("spec/internal/:memory", "crono-2.0.1")
     assert_match(%r{The gem contains a file 'spec/internal/:memory'}, error.message)
     assert_match(/characters in its name that are not allowed on Windows/, error.message)
     assert_match(/This is a problem with the 'crono-2.0.1' gem, not Rubygems/, error.message)
@@ -1335,7 +1335,7 @@ def test_extract_tar_gz_invalid_filename
       end
     end
 
-    e = assert_raise Gem::Package::InvalidFileNameError do
+    e = assert_raise Gem::Package::InvalidWindowsFileNameError do
       package.extract_tar_gz tgz_io, @destination
     end