remove validate_plugins!

it's not core to this PR, and can be debated separately

Author: ccutrer

bundler/lib/bundler/definition.rb

@@ -484,7 +484,6 @@ def ensure_equivalent_gemfile_and_lockfile(explicit_flag = false)
     def validate_runtime!
       validate_ruby!
       validate_platforms!
-      validate_plugins!
     end
 
     def validate_ruby!
@@ -520,19 +519,6 @@ def normalize_platforms
       @resolve = SpecSet.new(resolve.for(current_dependencies, @platforms))
     end
 
-    def validate_plugins!
-      missing_plugins_list = []
-      plugin_dependencies.each do |plugin|
-        missing_plugins_list << plugin unless Plugin.installed?(plugin.name)
-      end
-      missing_plugins_list.map! {|p| "#{p.name} (#{p.requirement})" }
-      if missing_plugins_list.size > 1
-        raise GemNotFound, "Plugins #{missing_plugins_list.join(", ")} are not installed"
-      elsif missing_plugins_list.any?
-        raise GemNotFound, "Plugin #{missing_plugins_list.join(", ")} is not installed"
-      end
-    end
-
     def add_platform(platform)
       return if @platforms.include?(platform)
 

spec/plugins/install_spec.rb

@@ -596,75 +596,6 @@ def exec(command, args)
     end
   end
 
-  it "fails bundle commands if plugins are not yet installed" do
-    allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
-
-    gemfile <<-G
-      source 'https://gem.repo2'
-      group :development do
-        plugin 'foo'
-      end
-      source 'https://gem.repo1' do
-        gem 'rake'
-      end
-    G
-
-    plugin_should_not_be_installed("foo")
-
-    bundle "check", raise_on_error: false
-    expect(err).to include("Plugin foo (>= 0) is not installed")
-
-    bundle "exec rake", raise_on_error: false
-    expect(err).to include("Plugin foo (>= 0) is not installed")
-
-    bundle "config set --local without development"
-    bundle "install"
-    bundle "config unset --local without"
-
-    plugin_should_not_be_installed("foo")
-
-    bundle "check", raise_on_error: false
-    expect(err).to include("Plugin foo (>= 0) is not installed")
-
-    bundle "exec rake", raise_on_error: false
-    expect(err).to include("Plugin foo (>= 0) is not installed")
-
-    plugin_should_not_be_installed("foo")
-
-    bundle "install"
-    plugin_should_be_installed("foo")
-
-    bundle "check"
-    bundle "exec rake -T", raise_on_error: false
-    expect(err).not_to include("Plugin foo (>= 0) is not installed")
-  end
-
-  it "fails bundle commands gracefully when a plugin index reference is left dangling" do
-    allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
-
-    build_lib "ga-plugin" do |s|
-      s.write "plugins.rb"
-    end
-
-    install_gemfile <<-G
-      source "https://gem.repo1"
-      plugin 'ga-plugin', :path => "#{lib_path("ga-plugin-1.0")}"
-    G
-
-    expect(out).to include("Installed plugin ga-plugin")
-    plugin_should_be_installed("ga-plugin")
-
-    FileUtils.rm_rf(lib_path("ga-plugin-1.0"))
-
-    plugin_should_not_be_installed("ga-plugin")
-
-    bundle "check", raise_on_error: false
-    expect(err).to include("Plugin ga-plugin (>= 0) is not installed")
-
-    bundle "exec rake -T", raise_on_error: false
-    expect(err).to include("Plugin ga-plugin (>= 0) is not installed")
-  end
-
   context "inline gemfiles" do
     it "installs the listed plugins" do
       code = <<-RUBY