Remove extra guard conditions to preserve existing behavior

The original PR added @Remote and aggregate_global_source? checks to
precompute_source_requirements_for_indirect_dependencies?, but these
conditions did not exist in the current codebase and would change the
method's behavior in cases where @Remote is false or
aggregate_global_source? is true. Since the goal is only to warn when
falling back to the insecure aggregate resolution path, keep the
existing condition as-is and just add the warning on the false branch.

Simplify the corresponding tests accordingly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: hsbt

bundler/lib/bundler/definition.rb

@@ -777,8 +777,6 @@ def start_resolution
     end
 
     def precompute_source_requirements_for_indirect_dependencies?
-      return false unless @remote && !sources.aggregate_global_source?
-
       if sources.non_global_rubygems_sources.all?(&:dependency_api_available?)
         true
       else

spec/bundler/definition_spec.rb

@@ -297,49 +297,45 @@
     let(:sources) { Bundler::SourceList.new }
     subject { Bundler::Definition.new(nil, [], sources, []) }
 
-    context "when remote and does not have multiple global sources" do
-      before do
-        subject.instance_variable_set(:@remote, true)
-        allow(sources).to receive(:aggregate_global_source?).and_return(false)
-        allow(sources).to receive(:non_global_rubygems_sources).and_return(non_global_rubygems_sources)
-      end
+    before do
+      allow(sources).to receive(:non_global_rubygems_sources).and_return(non_global_rubygems_sources)
+    end
 
-      context "when all the scoped sources contain a dependency API" do
-        let(:non_global_rubygems_sources) do
-          [
-            double("non-global-source-0", :dependency_api_available? => true, :to_s => "a"),
-            double("non-global-source-1", :dependency_api_available? => true, :to_s => "b"),
-          ]
-        end
+    context "when all the scoped sources implement a dependency API" do
+      let(:non_global_rubygems_sources) do
+        [
+          double("non-global-source-0", :dependency_api_available? => true, :to_s => "a"),
+          double("non-global-source-1", :dependency_api_available? => true, :to_s => "b"),
+        ]
+      end
 
-        it "will not raise a warning" do
-          expect(subject).not_to receive(:non_dependency_api_warning)
+      it "returns true without warning" do
+        expect(subject).not_to receive(:non_dependency_api_warning)
 
-          expect(subject.send(:precompute_source_requirements_for_indirect_dependencies?)).to be_truthy
-        end
+        expect(subject.send(:precompute_source_requirements_for_indirect_dependencies?)).to be_truthy
       end
+    end
 
-      context "when scoped sources do not contain a dependency API" do
-        let(:non_global_rubygems_sources) do
-          [
-            double("non-global-source-0", :dependency_api_available? => true, :to_s => "a"),
-            double("non-global-source-1", :dependency_api_available? => false, :to_s => "b"),
-            double("non-global-source-2", :dependency_api_available? => false, :to_s => "c"),
-          ]
-        end
+    context "when some scoped sources do not implement a dependency API" do
+      let(:non_global_rubygems_sources) do
+        [
+          double("non-global-source-0", :dependency_api_available? => true, :to_s => "a"),
+          double("non-global-source-1", :dependency_api_available? => false, :to_s => "b"),
+          double("non-global-source-2", :dependency_api_available? => false, :to_s => "c"),
+        ]
+      end
 
-        it "will raise a warning" do
-          expect(Bundler.ui).to receive(:warn).with(<<-W.strip)
+      it "returns false and warns about the non-API sources" do
+        expect(Bundler.ui).to receive(:warn).with(<<-W.strip)
 Your Gemfile contains scoped sources that don't implement a dependency API, namely:
 
   * b
   * c
 
 Using the above gem servers may result in installing unexpected gems. To resolve this warning, make sure you use gem servers that implement dependency APIs, such as gemstash or geminabox gem servers.
-          W
+        W
 
-          expect(subject.send(:precompute_source_requirements_for_indirect_dependencies?)).to be_falsy
-        end
+        expect(subject.send(:precompute_source_requirements_for_indirect_dependencies?)).to be_falsy
       end
     end
   end