Read BUNDLE_VERSION env var in BundlerVersionFinder#9538
Merged
Conversation
Bundler::Settings resolves the `version` setting from the BUNDLE_VERSION environment variable, but Gem::BundlerVersionFinder only consulted the .bundle/config file. As a result `BUNDLE_VERSION=system` was ignored at activation time and a lockfile-pinned bundler installed globally won out over the default gem. #9534
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates RubyGems’ Bundler activation/version selection logic so Gem::BundlerVersionFinder honors the BUNDLE_VERSION environment variable (matching Bundler’s own Settings precedence), instead of only reading .bundle/config. This addresses cases like BUNDLE_VERSION=system being ignored when a lockfile-pinned Bundler version is installed globally.
Changes:
- Teach
Gem::BundlerVersionFinder.bundle_config_versionto consultENV["BUNDLE_VERSION"]before reading local/global Bundler config files. - Add tests asserting
BUNDLE_VERSION=systemis respected and thatBUNDLE_VERSIONoverrides config-fileBUNDLE_VERSION. - Add tests ensuring an empty
BUNDLE_VERSIONenv var does not override config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/rubygems/bundler_version_finder.rb | Read BUNDLE_VERSION env var as the highest-priority source for the bundle “version” setting. |
| test/rubygems/test_gem_bundler_version_finder.rb | Add coverage for BUNDLE_VERSION env var behavior (system / overrides config / empty). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
72
to
+75
| def self.bundle_config_version | ||
| env_version = ENV["BUNDLE_VERSION"] | ||
| return env_version if env_version && !env_version.empty? | ||
|
|
| assert_nil bvf.bundler_version | ||
| end | ||
| end | ||
|
|
4 tasks
pull Bot
pushed a commit
to NeatNerdPrime/rubygems
that referenced
this pull request
May 14, 2026
Bundler treats "lockfile" as a special value for the version setting, meaning "use the version recorded in BUNDLED WITH". BundlerVersionFinder was passing the raw string to Gem::Version.new and raising ArgumentError both from the env var added in ruby#9538 and from .bundle/config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Fixes #9534
What is your fix for the problem, implemented in this PR?
Bundler::Settingsresolves theversionsetting from theBUNDLE_VERSIONenvironment variable, butGem::BundlerVersionFinderonly consulted the.bundle/configfile.As a result
BUNDLE_VERSION=systemwas ignored at activation time and a lockfile-pinned bundler installed globally won out over the default gem.Make sure the following tasks are checked