Silence coverage report output from coverage:report task#9577
Merged
Conversation
The collate run printed a "Coverage report generated for ..." line listing every per-process command name after each test/spec run. Mirror the stdout redirection already used in spec_helper's SimpleCov at_exit hook so the HTML report is still written without the noisy summary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to silence noisy console output produced by the coverage:report Rake task when generating a SimpleCov report from a collected resultset.
Changes:
- Redirects
$stdouttoFile::NULLduringSimpleCov.collateexecution. - Restores
$stdoutafter report generation using anensureclause.
Comments suppressed due to low confidence (1)
Rakefile:143
- Redirecting
$stdoutviaFile.openleaks the opened file handle (it’s never closed) and theensurecurrently resets$stdouttoSTDOUTeven when this task exits early (nexton missing resultset / missing simplecov). That can clobber an already-redirected$stdout(e.g., when rake output is being captured). Prefer saving the previous$stdout, wrapping only the collate in abegin/ensure, and closing the null IO.
$stdout = File.open(File::NULL, "w")
SimpleCov.collate Dir[resultset] do
coverage_dir "coverage"
add_filter "/test/"
add_filter "/spec/"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is your fix for the problem, implemented in this PR?
Surpressed the following output:
Make sure the following tasks are checked