Skip to content

Parse created_at via Time.new instead of Time.iso8601 #9583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 1 commit into from
Jun 2, 2026
+3 −4
Merged

Parse created_at via Time.new instead of Time.iso8601 #9583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions bundler/lib/bundler/endpoint_specification.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,10 @@ def parse_metadata(data)
when "created_at"
value = v.is_a?(Array) ? v.last : v
if value.is_a?(String)
require "time"

@byroot byroot Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't time be required on file load instead?

require in hot loops is always slow, but I suspect Time.iso8601 is faster than Time.new at least on latest Rubies.

Also Time#iso8601 was moved into core, perhaps Time.iso8601 should be as well? https://bugs.ruby-lang.org/issues/20707

@nobu nobu Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time.new appears to be an order of magnitude faster than Time.iso8601.

$ ruby -rtime -rbenchmark -e 's = ARGV.shift; n = 10000; Benchmark.bm {|x| x.report("Time.new") {n.times{Time.new(s)}}; x.report("Time.iso8601") {n.times{Time.iso8601(s)}}}' "2026-05-12T10:00:00Z"
                  user     system      total        real
Time.new      0.001954   0.000122   0.002076 (  0.002084)
Time.iso8601  0.012735   0.000192   0.012927 (  0.012939)

@hsbt hsbt Jun 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My rough benchmark Time.new is also 10x faster than Time.iso8601 on current Ruby.

ruby -e '
require "benchmark/ips"
require "time"
sample = "2026-05-30T08:52:10Z"
Benchmark.ips do |x|
  x.report("Time.new") { Time.new(sample) }
  x.report("Time.iso8601") { Time.iso8601(sample) }
  x.compare!
end
'

ruby 4.1.0dev (2026-06-02T04:45:55Z master 056ae1f926) +YJIT +MN +PRISM [arm64-darwin25]
Warming up --------------------------------------
            Time.new   348.371k i/100ms
        Time.iso8601    74.746k i/100ms
Calculating -------------------------------------
            Time.new      4.781M (±17.0%) i/s  (209.14 ns/i) -     24.038M in   5.027216s
        Time.iso8601    489.645k (±17.9%) i/s    (2.04 μs/i) -      2.467M in   5.037563s

Comparison:
    Time.new:  4781493.2 i/s
Time.iso8601:   489645.1 i/s - 9.77x  slower

@byroot byroot Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting. You'd think knowing the string is supposed to be in a precise format would allow iso8601 to be much faster, but I suppose it just mean no-one looked at optimizing it yet.

@byroot byroot Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... it's implemented with a regexp: https://github.com/ruby/ruby/blob/220f66a33eae1370aa964e7c07efdfdaf7bccddf/lib/time.rb#L626-L658

begin
@created_at = Time.iso8601(value)
@created_at = begin
Time.new(value)
rescue ArgumentError
@created_at = nil
nil
end
end
end
Expand Down
Loading