Fix ruby-core tarball detection in linked git worktrees#9616
Merged
Conversation
In a linked worktree `.git` is a gitdir pointer file, not a directory, so ruby_core_tarball? misdetected the checkout as a tarball and shipped_files mapped exe/ to libexec/, failing the whole suite with Errno::ENOENT in before(:suite). A tarball has no `.git` entry at all, so checking existence is enough. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Bundler spec helper logic that incorrectly treated linked git worktrees (where .git is a file pointing to the real gitdir) as tarball checkouts, which caused shipped_files to remap exe/ to libexec/ and break the test suite in that environment.
Changes:
- Update
ruby_core_tarball?to detect tarball checkouts by checking for existence of.gitrather than requiring it to be a directory. - Add clarifying comment explaining
.gitbeing a file in linked worktrees.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In a linked worktree
.gitis a gitdir pointer file, not a directory, soruby_core_tarball?misdetected the checkout as a tarball andshipped_filesmappedexe/tolibexec/, failing the whole test suite.What is your fix for the problem, implemented in this PR?
Use
exist?instead ofdirectory?.Make sure the following tasks are checked