Move Time to rely less on shared examples

Author: Earlopain

library/time/iso8601_spec.rb

@@ -1,7 +1,8 @@
 require_relative '../../spec_helper'
-require_relative 'shared/xmlschema'
 require 'time'
 
 describe "Time.iso8601" do
-  it_behaves_like :time_library_xmlschema, :iso8601
+  it "is an alias of Time.xmlschema" do
+    Time.method(:iso8601).should == Time.method(:xmlschema)
+  end
 end

library/time/rfc2822_spec.rb

@@ -1,7 +1,68 @@
 require_relative '../../spec_helper'
-require_relative 'shared/rfc2822'
 require 'time'
 
 describe "Time.rfc2822" do
-  it_behaves_like :time_rfc2822, :rfc2822
+  it "parses RFC-822 strings" do
+    t1 = (Time.utc(1976, 8, 26, 14, 30) + 4 * 3600)
+    t2 = Time.rfc2822("26 Aug 76 14:30 EDT")
+    t1.should == t2
+
+    t3 = Time.utc(1976, 8, 27, 9, 32) + 7 * 3600
+    t4 = Time.rfc2822("27 Aug 76 09:32 PDT")
+    t3.should == t4
+  end
+
+  it "parses RFC-2822 strings" do
+    t1 = Time.utc(1997, 11, 21, 9, 55, 6) + 6 * 3600
+    t2 = Time.rfc2822("Fri, 21 Nov 1997 09:55:06 -0600")
+    t1.should == t2
+
+    t3 = Time.utc(2003, 7, 1, 10, 52, 37) - 2 * 3600
+    t4 = Time.rfc2822("Tue, 1 Jul 2003 10:52:37 +0200")
+    t3.should == t4
+
+    t5 = Time.utc(1997, 11, 21, 10, 1, 10) + 6 * 3600
+    t6 = Time.rfc2822("Fri, 21 Nov 1997 10:01:10 -0600")
+    t5.should == t6
+
+    t7 = Time.utc(1997, 11, 21, 11, 0, 0) + 6 * 3600
+    t8 = Time.rfc2822("Fri, 21 Nov 1997 11:00:00 -0600")
+    t7.should == t8
+
+    t9 = Time.utc(1997, 11, 24, 14, 22, 1) + 8 * 3600
+    t10 = Time.rfc2822("Mon, 24 Nov 1997 14:22:01 -0800")
+    t9.should == t10
+
+    begin
+      Time.at(-1)
+    rescue ArgumentError
+      # ignore
+    else
+      t11 = Time.utc(1969, 2, 13, 23, 32, 54) + 3 * 3600 + 30 * 60
+      t12 = Time.rfc2822("Thu, 13 Feb 1969 23:32:54 -0330")
+      t11.should == t12
+
+      t13 = Time.utc(1969, 2, 13, 23, 32, 0) + 3 * 3600 + 30 * 60
+      t14 = Time.rfc2822(" Thu,
+      13
+        Feb
+          1969
+      23:32
+               -0330 (Newfoundland Time)")
+      t13.should == t14
+    end
+
+    t15 = Time.utc(1997, 11, 21, 9, 55, 6)
+    t16 = Time.rfc2822("21 Nov 97 09:55:06 GMT")
+    t15.should == t16
+
+    t17 = Time.utc(1997, 11, 21, 9, 55, 6) + 6 * 3600
+    t18 = Time.rfc2822("Fri, 21 Nov 1997 09 :   55  :  06 -0600")
+    t17.should == t18
+
+    -> {
+      # inner comment is not supported.
+      Time.rfc2822("Fri, 21 Nov 1997 09(comment):   55  :  06 -0600")
+    }.should.raise(ArgumentError)
+  end
 end

library/time/rfc822_spec.rb

@@ -1,7 +1,8 @@
 require_relative '../../spec_helper'
-require_relative 'shared/rfc2822'
 require 'time'
 
 describe "Time.rfc822" do
-  it_behaves_like :time_rfc2822, :rfc822
+  it "is an alias of Time.rfc2822" do
+    Time.method(:rfc822).should == Time.method(:rfc2822)
+  end
 end

library/time/shared/rfc2822.rb

@@ -1,7 +1,56 @@
 require_relative '../../spec_helper'
-require_relative 'shared/xmlschema'
 require 'time'
 
 describe "Time.xmlschema" do
-  it_behaves_like :time_library_xmlschema, :xmlschema
+  it "parses ISO-8601 strings" do
+    t = Time.utc(1985, 4, 12, 23, 20, 50, 520000)
+    s = "1985-04-12T23:20:50.52Z"
+    t.should == Time.xmlschema(s)
+    #s.should == t.xmlschema(2)
+
+    t = Time.utc(1996, 12, 20, 0, 39, 57)
+    s = "1996-12-19T16:39:57-08:00"
+    t.should == Time.xmlschema(s)
+    # There is no way to generate time string with arbitrary timezone.
+    s = "1996-12-20T00:39:57Z"
+    t.should == Time.xmlschema(s)
+    #assert_equal(s, t.xmlschema)
+
+    t = Time.utc(1990, 12, 31, 23, 59, 60)
+    s = "1990-12-31T23:59:60Z"
+    t.should == Time.xmlschema(s)
+    # leap second is representable only if timezone file has it.
+    s = "1990-12-31T15:59:60-08:00"
+    t.should == Time.xmlschema(s)
+
+    begin
+      Time.at(-1)
+    rescue ArgumentError
+      # ignore
+    else
+      t = Time.utc(1937, 1, 1, 11, 40, 27, 870000)
+      s = "1937-01-01T12:00:27.87+00:20"
+      t.should == Time.xmlschema(s)
+    end
+
+    # more
+
+    # (Time.utc(1999, 5, 31, 13, 20, 0) + 5 * 3600).should == Time.xmlschema("1999-05-31T13:20:00-05:00")
+    # (Time.local(2000, 1, 20, 12, 0, 0)).should == Time.xmlschema("2000-01-20T12:00:00")
+    # (Time.utc(2000, 1, 20, 12, 0, 0)).should == Time.xmlschema("2000-01-20T12:00:00Z")
+    # (Time.utc(2000, 1, 20, 12, 0, 0) - 12 * 3600).should == Time.xmlschema("2000-01-20T12:00:00+12:00")
+    # (Time.utc(2000, 1, 20, 12, 0, 0) + 13 * 3600).should == Time.xmlschema("2000-01-20T12:00:00-13:00")
+    # (Time.utc(2000, 3, 4, 23, 0, 0) - 3 * 3600).should == Time.xmlschema("2000-03-04T23:00:00+03:00")
+    # (Time.utc(2000, 3, 4, 20, 0, 0)).should == Time.xmlschema("2000-03-04T20:00:00Z")
+    # (Time.local(2000, 1, 15, 0, 0, 0)).should == Time.xmlschema("2000-01-15T00:00:00")
+    # (Time.local(2000, 2, 15, 0, 0, 0)).should == Time.xmlschema("2000-02-15T00:00:00")
+    # (Time.local(2000, 1, 15, 12, 0, 0)).should == Time.xmlschema("2000-01-15T12:00:00")
+    # (Time.utc(2000, 1, 16, 12, 0, 0)).should == Time.xmlschema("2000-01-16T12:00:00Z")
+    # (Time.local(2000, 1, 1, 12, 0, 0)).should == Time.xmlschema("2000-01-01T12:00:00")
+    # (Time.utc(1999, 12, 31, 23, 0, 0)).should == Time.xmlschema("1999-12-31T23:00:00Z")
+    # (Time.local(2000, 1, 16, 12, 0, 0)).should == Time.xmlschema("2000-01-16T12:00:00")
+    # (Time.local(2000, 1, 16, 0, 0, 0)).should == Time.xmlschema("2000-01-16T00:00:00")
+    # (Time.utc(2000, 1, 12, 12, 13, 14)).should == Time.xmlschema("2000-01-12T12:13:14Z")
+    # (Time.utc(2001, 4, 17, 19, 23, 17, 300000)).should == Time.xmlschema("2001-04-17T19:23:17.3Z")
+  end
 end