Add tests for combination of {bin,text}mode and external_encoding in ...#1076
Merged
eregon merged 2 commits intoruby:masterfrom Jan 4, 2026
Merged
Conversation
…IO.new The encoding option takes precedence over the binmode/textmode options. There are similar tests for passing the binmode argument in the mode argument.
Co-authored-by: Andrii Konchyn <andry.konchin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…IO.new
The encoding option takes precedence over the binmode/textmode options. There are similar tests for passing the binmode argument in the mode argument.