Remove Ruby 3.2 version guards#1258
Conversation
5e8f408 to
9aac6f7
Compare
|
Perhaps this is a bit premature? I think we should wait some amount of time after the eof to remove support for running the specs on 3.1. The impact to maintenance seems minimal. |
|
Since the work is (almost) done I don't see much point in delaying it. |
|
Whether 3.1 is EOF or not does not mean people are not still using it (and JRuby 9.4). Dropping support for running new specs on 3.1 means any spec behaviors that apply to 3.1 will not get tested and verified on those implementations. What's the rush to remove it? It's been EOF for just over a month. |
As I said, CRuby release branches do not update specs after branching off, so it's not tested (in ruby/ruby) anyway. CRuby has regularly removed support for EOF Rubies in specs, I suppose to avoid dead code in their repository, etc. It's part of regular maintenance, we drop specs for Ruby versions soon after they are EOL in ruby/spec, it's been like that for years. Finally, given the very few contributions from JRuby to ruby/spec since 2013 I'm not willing to spend any extra effort for it or such requests. |
The Set class is available as a built-in one without the need for require "set" in Ruby 3.2. https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
We do contribute specs when we find gaps in coverage. Most of our time is spent on addressing issues for production users of JRuby and working to get existing tests and specs passing. Given that JRuby development is now completely funded by our users, we have to prioritize user support over writing specs for new language features they are not going to be using. We appreciate your spending development time on specs and will try to contribute more now that JRuby 10 is up to 3.4ish compatibility. |
Ruby 3.1 EOF is 2025-03-26 so we don't need
ruby_version_is "3.2"guards anymore.https://www.ruby-lang.org/en/downloads/branches/