Skip to content

Fix "does not return a subclass instance" test for Time#-#1262

Merged
andrykonchin merged 1 commit into
ruby:masterfrom
herwinw:time_minus
May 11, 2025
Merged

Fix "does not return a subclass instance" test for Time#-#1262
andrykonchin merged 1 commit into
ruby:masterfrom
herwinw:time_minus

Conversation

@herwinw
Copy link
Copy Markdown
Member

@herwinw herwinw commented May 11, 2025

This looks like a copy-pase from Time#+, so this was testing the wrong method.

This looks like a copy-pase from Time#+
herwinw added a commit to herwinw/natalie that referenced this pull request May 11, 2025
This has been proposed upstream as ruby/spec#1262
@andrykonchin
Copy link
Copy Markdown
Member

Thank you!

@andrykonchin andrykonchin merged commit 82cdb5d into ruby:master May 11, 2025
11 checks passed
@herwinw herwinw deleted the time_minus branch May 11, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants