Skip to content

Add specs for MatchData#bytebegin, #byteend#1292

Merged
andrykonchin merged 1 commit into
ruby:masterfrom
trinistr:3.4-matchdata-beginend
Nov 6, 2025
Merged

Add specs for MatchData#bytebegin, #byteend#1292
andrykonchin merged 1 commit into
ruby:masterfrom
trinistr:3.4-matchdata-beginend

Conversation

@trinistr
Copy link
Copy Markdown
Contributor

@trinistr trinistr commented Nov 6, 2025

From #1265.

These are basically copies of existing #begin and #end specs.

@trinistr
Copy link
Copy Markdown
Contributor Author

trinistr commented Nov 6, 2025

By the way, am I correct in thinking there is no reason to leave behind encoding: utf-8?

@andrykonchin
Copy link
Copy Markdown
Member

Thank you!

By the way, am I correct in thinking there is no reason to leave behind encoding: utf-8?

Yes, seems so.

@andrykonchin andrykonchin merged commit a351e1a into ruby:master Nov 6, 2025
12 checks passed
@trinistr
Copy link
Copy Markdown
Contributor Author

trinistr commented Nov 6, 2025

Thank you for reviewing!

@trinistr trinistr deleted the 3.4-matchdata-beginend branch November 7, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants