Skip to content

Add tests for endless ranges to Comparable#clamp#1296

Merged
andrykonchin merged 1 commit into
ruby:masterfrom
trinistr:clamp-with-endless-ranges
Nov 7, 2025
Merged

Add tests for endless ranges to Comparable#clamp#1296
andrykonchin merged 1 commit into
ruby:masterfrom
trinistr:clamp-with-endless-ranges

Conversation

@trinistr
Copy link
Copy Markdown
Contributor

@trinistr trinistr commented Nov 7, 2025

Follow-up to my report in TruffleRuby truffleruby/truffleruby#3945. Comparable#clamp has been accepting endless ranges (of all varieties) since 2.7.

Note how only beginless ranges cause errors with exclusive end.

Comment thread core/comparable/clamp_spec.rb
Comment thread core/comparable/clamp_spec.rb Outdated
@andrykonchin
Copy link
Copy Markdown
Member

Looks good!. Could you please squash commits?

@trinistr trinistr force-pushed the clamp-with-endless-ranges branch from b062245 to 6430a32 Compare November 7, 2025 14:28
@trinistr
Copy link
Copy Markdown
Contributor Author

trinistr commented Nov 7, 2025

Done

@andrykonchin
Copy link
Copy Markdown
Member

Thank you!

@andrykonchin andrykonchin merged commit 7ca0217 into ruby:master Nov 7, 2025
12 checks passed
@trinistr trinistr deleted the clamp-with-endless-ranges branch November 7, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants