Skip to content

Commit 7e181ad

Browse files
authored
build: use non-deprecated compiler flag when building jruby extension (#202)
The current build uses deprecated Java compiler flags which do not fully guarantee runtime compatibility with the targeted Java runtime version. it doesn't cause any issues right right as the Java extension code is limited; but this would be better practice; especially as builds are executed with a non-locked Java runtime determined by `setup-ruby` defaults.
1 parent e8b66f8 commit 7e181ad

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

Rakefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ when "jruby"
1111
require 'rake/javaextensiontask'
1212
extask = Rake::JavaExtensionTask.new("stringio") do |ext|
1313
ext.lib_dir << "/#{ext.platform}"
14-
ext.source_version = '1.8'
15-
ext.target_version = '1.8'
14+
ext.release = '8'
1615
ext.ext_dir = 'ext/java'
1716
end
1817
libs = [extask.lib_dir]

0 commit comments

Comments
 (0)