Skip to content

Fix typo for %I delimiter check - #249

Merged
schneems merged 1 commit into
ruby:mainfrom
Earlopain:fix-qwords
Apr 7, 2026
Merged

Fix typo for %I delimiter check#249
schneems merged 1 commit into
ruby:mainfrom
Earlopain:fix-qwords

Conversation

@Earlopain

@Earlopain Earlopain commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

Also add tests for the other types which currently don't have one

@Earlopain
Fix typo for %I delimiter check
db2dca2 
Also add tests for the other types which currently don't have one
@schneems

schneems commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Thanks. To clarify for others, without this fix it will incorrectly report this code

          node.is_a?(Op) && %I[| ||].include?(node.value) &&

As missing a [

Failures:

  1) ExplainSyntax handles %I-style array
     Failure/Error: expect(explain.missing).to eq([])
     
       expected: []
            got: ["["]
     
       (compared using ==)

@schneems
schneems merged commit 62574de into ruby:main Apr 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Earlopain @schneems