Fix tracked file paths for subdirectories#103
Open
klly14 wants to merge 1 commit intorubyatscale:mainfrom
Open
Fix tracked file paths for subdirectories#103klly14 wants to merge 1 commit intorubyatscale:mainfrom
klly14 wants to merge 1 commit intorubyatscale:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--full-namefromgit ls-filesso tracked paths stay relative to the suppliedbase_pathfind_tracked_fileswhen called from a subdirectory inside a git repoRoot cause
git ls-files --full-namealways emits paths relative to the repository root.find_tracked_filesthen joined those repo-root-relative paths ontobase_path, which doubled nested prefixes like/repo/backend/backend/...when the caller ran from a subdirectory.Validation
cargo test tracked_files -- --nocapturecargo testcargo fmt --check