Conversation
perryqh
force-pushed
the
ph.blazing-fast-for-file
branch
from
5d99ebd to
66c46e9
Compare
perryqh
commented
Aug 11, 2025
| for_file_from_codeowners(run_config, file_path) | ||
| } else { | ||
| run_with_runner(run_config, |runner| runner.for_file(file_path)) | ||
| //run_with_runner(run_config, |runner| runner.for_file(file_path)) |
Contributor
Author
There was a problem hiding this comment.
Leaving the old code for now
jackboberg
approved these changes
Aug 12, 2025
Contributor
jackboberg
left a comment
jackboberg
left a comment
There was a problem hiding this comment.
I ran the compare_for_file against a large project, and all results matched except in cases where the team was correct but the reason was more specific. 💯
|
|
||
| hyperfine --warmup=2 --runs=3 --export-markdown tmp/codeowners_for_file_benchmarks.md \ | ||
| "../rubyatscale/codeowners-rs/target/release/codeowners for-file \"$1\"" \ | ||
| "bin/codeowners for_file \"$1\"" \ |
Contributor
There was a problem hiding this comment.
Suggested change
| "bin/codeowners for_file \"$1\"" \ | |
| "bin/codeowners-rs for-file \"$1\"" \ |
Contributor
There was a problem hiding this comment.
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
../rubyatscale/codeowners-rs/target/release/codeowners for-file "packs/technical_services/addresses/addresses/app/public/addresses.rb" |
23.1 ± 9.7 | 14.8 | 33.7 | 1.00 |
bin/codeowners-rs for-file "packs/technical_services/addresses/addresses/app/public/addresses.rb" |
4031.4 ± 32.1 | 4007.7 | 4067.9 | 174.56 ± 73.17 |
bin/codeownership for_file "packs/technical_services/addresses/addresses/app/public/addresses.rb" |
812.9 ± 18.0 | 799.1 | 833.2 | 35.20 ± 14.77 |
| hyperfine --warmup=2 --runs=3 --export-markdown tmp/codeowners_benchmarks_gv.md \ | ||
| '../rubyatscale/codeowners-rs/target/release/codeowners gv' \ | ||
| 'bin/codeowners-rs gv' No newline at end of file | ||
| 'bin/codeowners validate' \ |
Contributor
There was a problem hiding this comment.
Suggested change
| 'bin/codeowners validate' \ | |
| 'bin/codeowners-rs validate' \ |
Contributor
There was a problem hiding this comment.
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
../rubyatscale/codeowners-rs/target/release/codeowners gv |
3.492 ± 0.040 | 3.447 | 3.522 | 1.00 |
bin/codeowners-rs validate |
4.857 ± 0.107 | 4.772 | 4.976 | 1.39 ± 0.03 |
bin/codeownership validate |
60.224 ± 0.473 | 59.868 | 60.761 | 17.25 ± 0.24 |
🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assisted
for-fileoptimization.Also used in https://github.com/rubyatscale/fast_code_owners
Notes
The old for-file code will be removed in a follow up PR