Skip to content

Commit b68b0e6

Browse files
authored
Fix typos and grammatical issues (#179)
* Fix typos: POSIBLE_TYPES -> POSSIBLE_TYPES, configuratoin -> configuration * Fix grammatical issues in documentation and comments
1 parent ce04bad commit b68b0e6

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ Make sure there are no spaces between the comma-separated list of paths of direc
9090
`bin/packs move packs/destination_pack path/to/file.rb path/to/directory`
9191
9292
This is used for moving files into a pack (the pack must already exist).
93-
Note this works for moving files to packs from the monolith or from other packs
93+
Note this works for moving files to packs from the monolith or from other packs.
9494
9595
Make sure there are no spaces between the comma-separated list of paths of directories.
9696

advanced_usage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Packs.create_pack!(
1313
### Per-file Processors
1414
Your application may have specific needs when moving files. `Packs` gives a way to inject application-specific behavior into the file move process.
1515

16-
You can pass in an array of application specific behavior into the `per_file_processors` parameter of the main method.
16+
You can pass in an array of application-specific behavior into the `per_file_processors` parameter of the main method.
1717

1818
See `rubocop_post_processor.rb` as an example of renaming files in `.rubocop_todo.yml` automatically, which is something you may want to do (as you do not want to fix all style errors when you're just moving a file).
1919

lib/packs/cli.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ def add_dependency(from_pack, to_pack)
3939
exit_successfully
4040
end
4141

42-
POSIBLE_TYPES = T.let(%w[dependency privacy layer], T::Array[String])
42+
POSSIBLE_TYPES = T.let(%w[dependency privacy layer], T::Array[String])
4343
desc 'list_top_violations type [ packs/your_pack ]', 'List the top violations of a specific type for packs/your_pack.'
4444
long_desc <<~LONG_DESC
45-
Possible types are: #{POSIBLE_TYPES.join(', ')}.
45+
Possible types are: #{POSSIBLE_TYPES.join(', ')}.
4646
4747
Want to see who is depending on you? Not sure how your pack's code is being used in an unstated way? You can use this command to list the top dependency violations.
4848
@@ -60,7 +60,7 @@ def add_dependency(from_pack, to_pack)
6060
).void
6161
end
6262
def list_top_violations(type, pack_name = nil)
63-
raise StandardError, "Invalid type #{type}. Possible types are: #{POSIBLE_TYPES.join(', ')}" unless POSIBLE_TYPES.include?(type)
63+
raise StandardError, "Invalid type #{type}. Possible types are: #{POSSIBLE_TYPES.join(', ')}" unless POSSIBLE_TYPES.include?(type)
6464

6565
Packs.list_top_violations(
6666
type: type,
@@ -85,7 +85,7 @@ def make_public(*paths)
8585
desc 'move packs/destination_pack path/to/file.rb path/to/directory', 'Move files or directories from one pack to another'
8686
long_desc <<~LONG_DESC
8787
This is used for moving files into a pack (the pack must already exist).
88-
Note this works for moving files to packs from the monolith or from other packs
88+
Note this works for moving files to packs from the monolith or from other packs.
8989
9090
Make sure there are no spaces between the comma-separated list of paths of directories.
9191
LONG_DESC
@@ -135,8 +135,8 @@ def update
135135
sig { params(pack_names: String).void }
136136
def get_info(*pack_names)
137137
selected_types = options[:types].to_s.downcase.split(',')
138-
invalid_types = selected_types - POSIBLE_TYPES
139-
raise StandardError, "Invalid type(s): #{invalid_types.join(', ')}. Possible types are: #{POSIBLE_TYPES.join(', ')}" unless invalid_types.empty?
138+
invalid_types = selected_types - POSSIBLE_TYPES
139+
raise StandardError, "Invalid type(s): #{invalid_types.join(', ')}. Possible types are: #{POSSIBLE_TYPES.join(', ')}" unless invalid_types.empty?
140140

141141
Private.get_info(
142142
packs: parse_pack_names(pack_names),

lib/packs/private.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ def self.load_client_configuration
530530
def self.bust_cache!
531531
Packs.config.bust_cache!
532532
# This comes explicitly after `Packs.config.bust_cache!` because
533-
# otherwise `Packs.config` will attempt to reload the client configuratoin.
533+
# otherwise `Packs.config` will attempt to reload the client configuration.
534534
@loaded_client_configuration = false
535535
end
536536

0 commit comments

Comments
 (0)