Migrate tests off sorbet-runtime and replace type-erasure casts with total methods (#71)

* Migrate tests off sorbet-runtime and trim gemspec sorbet deps

The migration in #68 left the test suite using Sorbet's runtime DSL
(extend T::Sig, sig, T.must, T.unsafe, T.bind), which only worked
because packwerk transitively loaded sorbet-runtime. packwerk 3.3.0
drops sorbet-runtime, so the suite fails with 'uninitialized constant T'.

Rather than re-add a sorbet-runtime dependency, finish the migration in
test/ the same way as lib/:

- Translate sig blocks to #: RBS comments and drop extend T::Sig
- Replace requires_ancestor/T.bind with a Minitest::Runnable
  @requires_ancestor annotation in the fixture helper
- Convert T.must to '#: as !nil' and T.unsafe to '#: as untyped' casts

Also drop the redundant 'sorbet-static' dev dependency (the 'sorbet'
gem already depends on it).

* Avoid untyped cast in integration specs

Use Enumerable#any? with the class as a === pattern instead of casting
the abstract Packwerk::Checker element to untyped to call is_a?. This
keeps the check fully typed (no type erasure).

* Use Array#fetch(-1) instead of last with a non-nil cast

fetch(-1) returns a non-nil element type, so no '#: as !nil' cast is
needed (and it raises IndexError rather than silently returning nil).

* Use total methods instead of non-nil casts in privacy checker

- publicized_locations.fetch(location) instead of [] with '#: as !nil'
  (the key is guaranteed present by the preceding key? guard)
- lines.first(5) instead of lines[0..4] with '#: as !nil' (first(n)
  returns a non-nil Array)

Author: dduugg

Gemfile.lock

@@ -268,7 +268,6 @@ DEPENDENCIES
   rubocop-gusto
   rubocop-sorbet!
   sorbet
-  sorbet-static
   tapioca
 
 BUNDLED WITH

lib/packwerk/privacy/checker.rb

@@ -25,7 +25,7 @@ def publicized_location?(location)
             publicized_locations[location] = check_for_publicized_sigil(location)
           end
 
-          publicized_locations[location] #: as !nil
+          publicized_locations.fetch(location)
         end
 
         #: (String location) -> bool
@@ -35,8 +35,7 @@ def check_for_publicized_sigil(location)
 
         #: (Array[String] lines) -> bool
         def content_contains_sigil?(lines)
-          first_lines = lines[0..4] #: as !nil
-          first_lines.any? { |l| l =~ PUBLICIZED_SIGIL_REGEX }
+          lines.first(5).any? { |l| l =~ PUBLICIZED_SIGIL_REGEX }
         end
       end
 

packwerk-extensions.gemspec

@@ -34,6 +34,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'rubocop-gusto'
   spec.add_development_dependency 'sorbet'
-  spec.add_development_dependency 'sorbet-static'
   spec.add_development_dependency 'tapioca'
 end

test/integration/extension_test.rb

@@ -6,8 +6,6 @@
 module Packwerk
   module Privacy
     class ExtensionTest < Minitest::Test
-      extend T::Sig
-
       include ApplicationFixtureHelper
 
       setup do
@@ -22,10 +20,7 @@ class ExtensionTest < Minitest::Test
         use_template(:extended)
         Packwerk::Checker.all
         assert_equal(Packwerk::Checker.all.count, 5)
-        found_checker = Packwerk::Checker.all.any? do |checker|
-          T.unsafe(checker).is_a?(Packwerk::Privacy::Checker)
-        end
-        assert found_checker
+        assert(Packwerk::Checker.all.any?(Packwerk::Privacy::Checker))
       end
     end
   end

test/integration/extension_with_unrecognized_config_test.rb

@@ -6,8 +6,6 @@
 module Packwerk
   module Privacy
     class ExtensionWithUnrecognizedConfigTest < Minitest::Test
-      extend T::Sig
-
       include ApplicationFixtureHelper
 
       setup do
@@ -22,10 +20,7 @@ class ExtensionWithUnrecognizedConfigTest < Minitest::Test
         use_template(:with_unrecognized_config)
         Packwerk::Checker.all
         assert_equal(Packwerk::Checker.all.count, 5)
-        found_checker = Packwerk::Checker.all.any? do |checker|
-          T.unsafe(checker).is_a?(Packwerk::Privacy::Checker)
-        end
-        assert found_checker
+        assert(Packwerk::Checker.all.any?(Packwerk::Privacy::Checker))
       end
     end
   end

test/support/application_fixture_helper.rb

@@ -1,14 +1,11 @@
 # typed: true
 # frozen_string_literal: true
 
+# @requires_ancestor: Minitest::Runnable
 module ApplicationFixtureHelper
   TEMP_FIXTURE_DIR = ROOT.join('tmp', 'fixtures').to_s
   DEFAULT_TEMPLATE = :minimal
 
-  extend T::Helpers
-
-  requires_ancestor { Kernel }
-
   def setup_application_fixture
     @old_working_dir = Dir.pwd
   end
@@ -80,13 +77,12 @@ def using_template?
   end
 
   def copy_dir(path)
-    root = FileUtils.mkdir_p(fixture_path).last
-    FileUtils.cp_r("#{path}/.", T.must(root))
+    root = FileUtils.mkdir_p(fixture_path).fetch(-1)
+    FileUtils.cp_r("#{path}/.", root)
     @app_dir = root
   end
 
   def fixture_path
-    T.bind(self, Minitest::Runnable)
     File.join(TEMP_FIXTURE_DIR, "#{name}-#{Time.now.strftime('%Y_%m_%d_%H_%M_%S')}")
   end
 end

test/unit/folder_privacy/checker_test.rb

@@ -6,7 +6,6 @@
 module Packwerk
   module FolderPrivacy
     class CheckerTest < Minitest::Test
-      extend T::Sig
       include FactoryHelper
       include RailsApplicationFixtureHelper
 
@@ -61,7 +60,7 @@ class CheckerTest < Minitest::Test
 
       private
 
-      sig { returns(Checker) }
+      #: -> Checker
       def folder_privacy_checker
         FolderPrivacy::Checker.new
       end

test/unit/folder_privacy/validator_test.rb

@@ -9,7 +9,6 @@
 module Packwerk
   module FolderPrivacy
     class ValidatorTest < Minitest::Test
-      extend T::Sig
       include ApplicationFixtureHelper
       include RailsApplicationFixtureHelper
 
@@ -40,7 +39,7 @@ class ValidatorTest < Minitest::Test
         assert result.ok?
       end
 
-      sig { returns(Packwerk::FolderPrivacy::Validator) }
+      #: -> Packwerk::FolderPrivacy::Validator
       def validator
         @validator ||= Packwerk::FolderPrivacy::Validator.new
       end

test/unit/layer/checker_architecture_test.rb

@@ -6,7 +6,6 @@
 module Packwerk
   module Layer
     class CheckerTest < Minitest::Test
-      extend T::Sig
       include FactoryHelper
       include RailsApplicationFixtureHelper
 
@@ -120,7 +119,7 @@ def utility_pack(enforce: false)
 
       private
 
-      sig { returns(Checker) }
+      #: -> Checker
       def layer_checker
         Packwerk::Layer::Checker.new
       end

test/unit/layer/checker_test.rb

@@ -6,7 +6,6 @@
 module Packwerk
   module Layer
     class CheckerTest < Minitest::Test
-      extend T::Sig
       include FactoryHelper
       include RailsApplicationFixtureHelper
 
@@ -124,7 +123,7 @@ def utility_pack(enforce: false)
 
       private
 
-      sig { returns(Checker) }
+      #: -> Checker
       def layer_checker
         Packwerk::Layer::Checker.new
       end