Require sorbet-runtime from each checker entrypoint#67
Closed
beauraF wants to merge 1 commit into
Closed
Conversation
packwerk 3.3.0 dropped its runtime dependency on sorbet-runtime. The README documents adding individual checkers to packwerk.yml's `require:` list (e.g. `- packwerk/privacy/checker`), which bypasses the umbrella `packwerk-extensions.rb` entrypoint where `require 'sorbet-runtime'` currently lives. Once packwerk no longer pulls sorbet-runtime in for us, evaluating a checker file hits `extend T::Sig` / `T.let` before `T` is defined and fails with `uninitialized constant Packwerk::Privacy::T (NameError)`. Load sorbet-runtime at the top of each documented entrypoint so individual checker requires are self-sufficient. The require cascades through `package.rb`, `validator.rb`, etc., which also use `T::` constants. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packwerk3.3.0 dropped its runtime dependency onsorbet-runtimepackwerk.yml'srequire:list (e.g.- packwerk/privacy/checker), which bypasseslib/packwerk-extensions.rb— the only place currently callingrequire 'sorbet-runtime'sorbet-runtimepreloaded, evaluating a checker file hitsextend T::Sig/T.letbeforeTexists and fails withuninitialized constant Packwerk::Privacy::T (NameError)Fix
Add
require 'sorbet-runtime'at the top of each documented entrypoint:lib/packwerk/privacy/checker.rblib/packwerk/visibility/checker.rblib/packwerk/folder_privacy/checker.rblib/packwerk/layer/checker.rbThe require cascades through
package.rb/validator.rb(andconfig.rb/layers.rbforlayer), which also useT::constants.sorbet-runtimeis already declared as a runtime gemspec dependency, so it's always in the bundle. Existing umbrella entrypoint and test helper continue to work unchanged.Reproduction
Before this change, with packwerk 3.3.0 in the bundle:
After: