Skip to content

Commit 18b888e

Browse files
committed
Refine TODO comments on console.debug calls in reportError
The two calls immediately preceding showWarningMessage note that the same stderr is already surfaced via the proper VS Code notification channel. The rest remain as generic "likely redundant" notes.
1 parent af0b4ec commit 18b888e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/packwerk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,13 +188,13 @@ export class Packwerk {
188188
);
189189
return true;
190190
} else if (error && (<any>error).code === 127 && this.config.showWarnings) {
191-
// TODO: likely redundant debug logging; consider removing
191+
// TODO: likely redundant; the same stderr is already surfaced via showWarningMessage below
192192
// eslint-disable-next-line no-console
193193
console.debug('[DEBUG] Showing error with code 127', stderr);
194194
vscode.window.showWarningMessage(stderr);
195195
return true;
196196
} else if (errorOutput.length > 0 && this.config.showWarnings) {
197-
// TODO: likely redundant debug logging; consider removing
197+
// TODO: likely redundant; the same stderr is already surfaced via showWarningMessage below
198198
// eslint-disable-next-line no-console
199199
console.debug('[DEBUG] Showing error with errorOutput.length > 0', stderr);
200200
vscode.window.showWarningMessage(stderr);

0 commit comments

Comments
 (0)