Skip to content

Commit ca5a1f8

Browse files
committed
Remove TODO comments from non-redundant console.debug suppressions
1 parent 18b888e commit ca5a1f8

4 files changed

Lines changed: 0 additions & 8 deletions

File tree

src/configuration.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export const getConfig: () => PackwerkConfig = () => {
1515
const conf = vs.workspace.getConfiguration('ruby.packwerk');
1616
let executable = conf.get('executable', 'bin/packwerk check');
1717

18-
// TODO: likely redundant debug logging; consider removing
1918
// eslint-disable-next-line no-console
2019
console.debug(`[DEBUG] Parsing config, found executable '${executable}'`);
2120

src/outputParser.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export function parseOutput(str: string): PackwerkOutput {
1010

1111
let arr: RegExpExecArray;
1212
while ((arr = regex.exec(str)) !== null) {
13-
// TODO: likely redundant debug logging; consider removing
1413
// eslint-disable-next-line no-console
1514
console.log('[DEBUG] Parsed regular expression', arr);
1615
const file = arr[1];

src/packwerk.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,13 @@ export class Packwerk {
4848
let relativeFileName = fileName.replace(currentPath + '/', '');
4949

5050
let onDidExec = (error: Error, stdout: string, stderr: string) => {
51-
// TODO: likely redundant debug logging; consider removing
5251
// eslint-disable-next-line no-console
5352
console.debug('[DEBUG] Finished running command, in onDidExec');
5453
// eslint-disable-next-line no-console
5554
console.debug('[DEBUG] Error, stderr', error, stderr);
5655
this.reportError(error, stderr);
5756
let packwerk = this.parse(stdout);
5857
if (packwerk === undefined || packwerk === null) {
59-
// TODO: likely redundant debug logging; consider removing
6058
// eslint-disable-next-line no-console
6159
console.debug('[DEBUG] packwerk is undefined or null, returning from onDidExec');
6260
return;
@@ -81,7 +79,6 @@ export class Packwerk {
8179
/[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g, '');
8280

8381
const message = decolorizedMessage;
84-
// TODO: likely redundant debug logging; consider removing
8582
// eslint-disable-next-line no-console
8683
console.debug('[DEBUG] Adding vscode.Diagnostic:', { range, message });
8784
const diagnostic = new vscode.Diagnostic(
@@ -138,7 +135,6 @@ export class Packwerk {
138135
cb: (err: Error, stdout: string, stderr: string) => void
139136
): cp.ChildProcess {
140137
let command = `${this.config.executable} ${fileName}`;
141-
// TODO: likely redundant debug logging; consider removing
142138
// eslint-disable-next-line no-console
143139
console.debug(`[DEBUG] Running command ${command}`);
144140

@@ -151,7 +147,6 @@ export class Packwerk {
151147
private parse(output: string): PackwerkOutput | null {
152148
let packwerk: PackwerkOutput;
153149
if (output.length < 1) {
154-
// TODO: likely redundant debug logging; consider removing
155150
// eslint-disable-next-line no-console
156151
console.debug(`[DEBUG] Output is ${output}`);
157152
let message = `command ${this.config.executable} returns empty output! please check configuration.`;

src/taskQueue.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ export class TaskQueue {
9696
let uriString = uri.toString(true);
9797
this.tasks.forEach((task) => {
9898
if (task.uri.toString(true) === uriString) {
99-
// TODO: likely redundant debug logging; consider removing
10099
// eslint-disable-next-line no-console
101100
console.debug(`[DEBUG] Canceling existing task for ${task.uri}`);
102101
task.cancel();

0 commit comments

Comments
 (0)