Allow violations to be set on a package (#30)

* Allow violations to be set on a package

* Remove the need for oddly named `stored_violations`

Author: shageman

lib/parse_packwerk/package.rb

@@ -11,6 +11,7 @@ class Package < T::Struct
     const :metadata, MetadataYmlType
     const :dependencies, T::Array[String]
     const :config, T::Hash[T.untyped, T.untyped]
+    const :violations, T.nilable(T::Array[Violation])
 
     sig { params(pathname: Pathname).returns(Package) }
     def self.from(pathname)
@@ -29,17 +30,23 @@ def self.from(pathname)
         metadata: package_loaded_yml[METADATA] || {},
         dependencies: package_loaded_yml[DEPENDENCIES] || [],
         config: package_loaded_yml,
+        violations: PackageTodo.from(PackageTodo.yml(directory(package_name))).violations
       )
     end
 
+    sig { params(package_name: String).returns(::Pathname) }
+    def self.directory(package_name)
+      Pathname.new(package_name).cleanpath
+    end
+
     sig { returns(Pathname) }
     def yml
       Pathname.new(name).join(PACKAGE_YML_NAME).cleanpath
     end
 
     sig { returns(Pathname) }
     def directory
-      Pathname.new(name).cleanpath
+      self.class.directory(self.name)
     end
 
     sig { returns(Pathname) }
@@ -56,10 +63,5 @@ def enforces_dependencies?
     def enforces_privacy?
       enforce_privacy
     end
-
-    sig { returns(T::Array[Violation]) }
-    def violations
-      PackageTodo.for(self).violations
-    end
   end
 end

lib/parse_packwerk/package_todo.rb

@@ -9,8 +9,7 @@ class PackageTodo < T::Struct
 
     sig { params(package: Package).returns(PackageTodo) }
     def self.for(package)
-      package_todo_yml_pathname = package.directory.join(PACKAGE_TODO_YML_NAME)
-      PackageTodo.from(package_todo_yml_pathname)
+      PackageTodo.from(self.yml(package.directory))
     end
 
     sig { params(pathname: Pathname).returns(PackageTodo) }
@@ -42,5 +41,10 @@ def self.from(pathname)
         )
       end
     end
+    
+    sig { params(dirname: Pathname).returns(Pathname) }
+    def self.yml(dirname)
+      dirname.join(PACKAGE_TODO_YML_NAME).cleanpath
+    end
   end
 end