Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
persist-credentials: false
- name: Tag and Push Gem
id: tag-and-push-gem
uses: discourse/publish-rubygems-action@v3
Expand All @@ -17,6 +19,7 @@
GIT_NAME: ${{secrets.GUSTO_GIT_NAME}}
RUBYGEMS_API_KEY: ${{secrets.RUBYGEMS_API_KEY}}
- name: Create GitHub Release
# zizmor: ignore[template-injection] gem_version comes from a trusted prior step
run: gh release create v${{steps.tag-and-push-gem.outputs.gem_version}} --generate-notes
if: ${{ steps.tag-and-push-gem.outputs.new_version == 'true' }}
env:
Expand All @@ -25,13 +28,10 @@
runs-on: ubuntu-latest
needs: [deploy]
if: ${{ failure() && github.ref == 'refs/heads/main' }}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
steps:
- uses: slackapi/slack-github-action@v1.25.0
- uses: slackapi/slack-github-action@v3

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: incoming-webhook
payload: |
{
"text": "${{ github.repository }}/${{ github.ref }}: FAILED\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
}
text: "${{ github.repository }}/${{ github.ref }}: FAILED\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
25 changes: 15 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
BUNDLE_GEMFILE: Gemfile
name: "Run tests: Ruby ${{ matrix.ruby }}"
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
persist-credentials: false
- name: Install ripgrep
run: sudo apt-get install -y ripgrep
- name: Set up Ruby ${{ matrix.ruby }}
Expand All @@ -36,12 +38,15 @@
bundler-cache: true
ruby-version: ${{ matrix.ruby }}
- name: Run tests
# zizmor: ignore[template-injection] workflow_call inputs are controlled by the caller
run: ${{ inputs.test-command }}
static_type_check:
name: "Type Check"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
persist-credentials: false
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -53,25 +58,25 @@
runs-on: ubuntu-latest
name: "Linter"
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
persist-credentials: false
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true
ruby-version: 3.4
- name: Run linter
# zizmor: ignore[template-injection] workflow_call inputs are controlled by the caller
run: ${{ inputs.linter-command }}
notify_on_failure:
runs-on: ubuntu-latest
needs: [run_tests, static_type_check, run_linter]
if: ${{ failure() && github.ref == 'refs/heads/main' }}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
steps:
- uses: slackapi/slack-github-action@v1.25.0
- uses: slackapi/slack-github-action@v3

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: incoming-webhook
payload: |
{
"text": "${{ github.repository }}/${{ github.ref }}: FAILED\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
}
text: "${{ github.repository }}/${{ github.ref }}: FAILED\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
- uses: actions/stale@v10

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
stale-issue-message: 'This issue has been marked stale because it has been open for six months with no activity. To prevent this issue from automatically being closed in one week, update it or remove the stale label.'
stale-pr-message: 'This PR has been marked stale because it has been open for six months with no activity. To prevent this PR from automatically being closed in one week, update it or remove the stale label.'
Expand Down
25 changes: 25 additions & 0 deletions .github/workflows/zizmor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: GitHub Actions Security Analysis

on:
push:
branches: [main]
pull_request:
branches: ["**"]

permissions: {}

jobs:
zizmor:
runs-on: ubuntu-latest
permissions:
security-events: write
contents: read
actions: read
steps:
- name: Checkout repository
uses: actions/checkout@v6

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
persist-credentials: false

- name: Run zizmor
uses: zizmorcore/zizmor-action@v0.5.3

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
5 changes: 5 additions & 0 deletions .zizmor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
rules:
unpinned-uses:
disable: true
secrets-outside-env:
disable: true