Bump standardrb to 1.0.1 (#636)

johnpaulashenfelter · web-flow · commit 9dbeb2ec85ad · 2023-07-30T08:10:24.000-04:00
* Bump standardrb to 1.0.1

* Run standardrb --fix after upgrade

* Regenerate standard_todo file

* Remove rubocop.yml now that standardrb is used

* Regen todo file and patch a file todo was not workting properly with

* Remove rubocop-rails
diff --git a/backend/.rubocop.yml b/backend/.rubocop.yml
diff --git a/backend/.standard_todo.yml b/backend/.standard_todo.yml
@@ -2,18 +2,32 @@
 # Remove from this list as you refactor files.
 ---
 ignore:
-- app/controllers/api/v1/aws_ses_controller.rb
-- app/controllers/api/v1/profiles_controller.rb
-- app/controllers/api/v1/sessions_controller.rb
-- app/jobs/group_top_posts_job.rb
-- app/models/search.rb
-- app/services/charts_pattern.rb
-- config/initializers/00_app.rb
-- config/puma.rb
-- config/routes.rb
-- lib/tasks/app.rake
-- lib/tasks/hbi_completeness.rake
-- lib/tasks/trackables.rake
-- lib/tasks/usda.rake
-- spec/models/food_spec.rb
-- spec/spec_helper.rb
+- app/controllers/api/v1/aws_ses_controller.rb:
+  - Security/Open
+- app/controllers/api/v1/profiles_controller.rb:
+  - Style/SafeNavigation
+- app/controllers/api/v1/sessions_controller.rb:
+  - Style/SafeNavigation
+- app/jobs/group_top_posts_job.rb:
+  - Style/SafeNavigation
+- app/models/search.rb:
+  - Lint/Void
+- app/services/charts_pattern.rb:
+  - Lint/DuplicateMethods
+  - Layout/SpaceInsideHashLiteralBraces
+  - Style/QuotedSymbols
+- lib/tasks/app.rake:
+  - Lint/ConstantDefinitionInBlock
+  - Style/GlobalStdStream
+  - Lint/Loop
+- lib/tasks/hbi_completeness.rake:
+  - Lint/ConstantDefinitionInBlock
+- lib/tasks/trackables.rake:
+  - Lint/ConstantDefinitionInBlock
+  - Lint/UselessAssignment
+- lib/tasks/usda.rake:
+  - Lint/ConstantDefinitionInBlock
+- spec/models/food_spec.rb:
+  - Lint/ConstantDefinitionInBlock
+- spec/spec_helper.rb:
+  - Style/StringLiterals
diff --git a/backend/Gemfile b/backend/Gemfile
@@ -86,7 +86,6 @@ group :development do
   gem "better_errors", "~>2.1"
   gem "foreman", require: false
   gem "letter_opener"
-  gem "rubocop-rails", require: false
 end
 
 group :test do
diff --git a/backend/Gemfile.lock b/backend/Gemfile.lock
@@ -191,6 +191,8 @@ GEM
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     i18n_data (0.13.0)
+    json (2.6.3)
+    json (2.6.3-java)
     jwt (2.3.0)
     kaminari-actionview (1.2.1)
       actionview
@@ -200,10 +202,12 @@ GEM
       kaminari-core (~> 1.0)
       mongoid
     kdtree (0.4)
+    language_server-protocol (3.17.0.3)
     launchy (2.5.2)
       addressable (~> 2.8)
     letter_opener (1.8.1)
       launchy (>= 2.2, < 3)
+    lint_roller (1.1.0)
     loofah (2.21.3)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
@@ -377,24 +381,21 @@ GEM
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
     rspec-support (3.12.1)
-    rubocop (1.20.0)
+    rubocop (1.52.1)
+      json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.9.1, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
-    rubocop-performance (1.11.5)
+    rubocop-performance (1.18.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.15.2)
-      activesupport (>= 4.2.0)
-      rack (>= 1.1)
-      rubocop (>= 1.7.0, < 2.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     seedbank (0.5.0)
@@ -422,10 +423,19 @@ GEM
       actionpack (>= 5.2)
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
-    standard (1.3.0)
-      rubocop (= 1.20.0)
-      rubocop-performance (= 1.11.5)
-    standardrb (1.0.0)
+    standard (1.30.1)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.52.0)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.1.0)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.1.2)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.18.0)
+    standardrb (1.0.1)
       standard
     symmetric-encryption (4.4.0)
       coercible (~> 1.0)
@@ -505,7 +515,6 @@ DEPENDENCIES
   rails_12factor
   rake
   rspec-rails
-  rubocop-rails
   ruby-progressbar
   seedbank
   shoulda-matchers
diff --git a/backend/app/controllers/api/v1/charts_pattern_controller.rb b/backend/app/controllers/api/v1/charts_pattern_controller.rb
@@ -8,9 +8,9 @@ def index
         start_at = (charts_pattern_params[:start_at].to_date - offset.days).to_s
 
         end_date = charts_pattern_params[:end_at].to_date
-        end_at = (Time.current.to_date == end_date ? end_date : (end_date + offset.days)).to_s
+        end_at = ((Time.current.to_date == end_date) ? end_date : (end_date + offset.days)).to_s
 
-        @patterns = Pattern.where(id: {'$in': charts_pattern_params[:pattern_ids] || []})
+        @patterns = Pattern.where(id: {"$in": charts_pattern_params[:pattern_ids] || []})
 
         @extended_patterns = @patterns.map do |pattern|
           pattern.extend(PatternExtender).form_chart_data(start_at: start_at,
diff --git a/backend/app/jobs/merge_trackables/dispatcher.rb b/backend/app/jobs/merge_trackables/dispatcher.rb
@@ -3,7 +3,7 @@ class MergeTrackables::Dispatcher
 
   def perform(trackable_type, translation = nil)
     trackable_class = trackable_type.capitalize.constantize
-    searchable_attr = trackable_class.name == "Food" ? "long_desc" : "name"
+    searchable_attr = (trackable_class.name == "Food") ? "long_desc" : "name"
 
     return find_duplicates(trackable_type, trackable_class, translation, searchable_attr) if translation.present?
 
diff --git a/backend/app/jobs/same_trackables_job.rb b/backend/app/jobs/same_trackables_job.rb
@@ -6,7 +6,7 @@ def perform(options)
     translation = options["translation"]
 
     trackable_class = trackable_type.capitalize.constantize
-    searchable_attr = trackable_class.name == "Food" ? "long_desc" : "name"
+    searchable_attr = (trackable_class.name == "Food") ? "long_desc" : "name"
 
     [].tap do |array|
       if translation.present?
diff --git a/backend/app/models/notification.rb b/backend/app/models/notification.rb
@@ -19,7 +19,7 @@ class Notification
   index notificateable_id: 1, notificateable_type: 1
 
   def set_defaults
-    assign_attributes(post_id: (notificateable._type == "Comment" ? notificateable.post_id : notificateable.id).to_s)
+    assign_attributes(post_id: ((notificateable._type == "Comment") ? notificateable.post_id : notificateable.id).to_s)
   end
 
   class << self
diff --git a/backend/app/models/post.rb b/backend/app/models/post.rb
@@ -29,7 +29,7 @@ def update_counters
   end
 
   def self.fts(q)
-    where('$text': {'$search': q, '$language': I18n.locale.to_s})
+    where("$text": {"$search": q, "$language": I18n.locale.to_s})
   end
 
   def self.by_followings(followings)
diff --git a/backend/app/models/profile.rb b/backend/app/models/profile.rb
@@ -99,7 +99,7 @@ def age
     today = Time.zone.today
     age = today.year - birth_date.year
 
-    today < birth_date + age.years ? age - 1 : age
+    (today < birth_date + age.years) ? age - 1 : age
   end
 
   def ethnicity_ids
diff --git a/backend/app/serializers/api/v1/checkin_serializer.rb b/backend/app/serializers/api/v1/checkin_serializer.rb
@@ -39,7 +39,7 @@ def postal_code
         plural_name = name.pluralize
 
         define_method(plural_name.to_sym) do
-          query = object.includes ? {"#{name}_id" => {'$in': (object.includes[plural_name] || []).map(&:to_i)}} : {}
+          query = object.includes ? {"#{name}_id" => {"$in": (object.includes[plural_name] || []).map(&:to_i)}} : {}
 
           object.send(plural_name).where(query)
         end
diff --git a/backend/app/services/checkin/creator.rb b/backend/app/services/checkin/creator.rb
@@ -65,10 +65,7 @@ def create_or_update_trackable_usages(checkin)
       checkin_trackables_method = trackable_class_name.downcase.pluralize
       checkin.send(checkin_trackables_method).each do |checkin_trackable|
         trackable_id = checkin_trackable.send(trackable_id_method)
-        TrackableUsage.create_or_update_by(
-          user: user,
-          trackable: trackable_class.find(trackable_id)
-        )
+        TrackableUsage.create_or_update_by(user: user, trackable: trackable_class.find(trackable_id))
       end
     end
   end
diff --git a/backend/app/services/summary_posts.rb b/backend/app/services/summary_posts.rb
@@ -15,7 +15,7 @@ def initialize(user)
 
   def show_list
     posts = list.first(SUMMARY_POSTS)
-    posts.count == SUMMARY_POSTS ? posts : posts + add_last_new_posts(SUMMARY_POSTS - posts.count, posts.map(&:_id))
+    (posts.count == SUMMARY_POSTS) ? posts : posts + add_last_new_posts(SUMMARY_POSTS - posts.count, posts.map(&:_id))
   end
 
   def list
diff --git a/backend/config/initializers/devise.rb b/backend/config/initializers/devise.rb
@@ -237,9 +237,7 @@
   # Add a new OmniAuth provider. Check the wiki for more information on setting
   # up on your models and hooks.
   # config.omniauth :github, 'APP_ID', 'APP_SECRET', scope: 'user,public_repo'
-  config.omniauth :facebook, ENV["FACEBOOK_APP_ID"], ENV["FACEBOOK_APP_SECRET"], {
-
-  }
+  config.omniauth :facebook, ENV["FACEBOOK_APP_ID"], ENV["FACEBOOK_APP_SECRET"], {}
   # ==> Warden configuration
   # If you want to use other strategies, that are not supported by Devise, or
   # change the failure app, you can configure them inside the config.warden block.
diff --git a/backend/spec/models/ability/condition_spec.rb b/backend/spec/models/ability/condition_spec.rb
@@ -64,7 +64,7 @@
 
     context "popular conditions" do
       before { create_list(:user_condition, Flaredown.config.trackables_min_popularity, condition: popular_condition) }
-      let(:popular_condition_ids) { Ability.new(user).send("popular_trackable_ids", "Condition") }
+      let(:popular_condition_ids) { Ability.new(user).send(:popular_trackable_ids, "Condition") }
 
       it { expect(popular_condition_ids).to eq([popular_condition.id]) }
     end
diff --git a/backend/spec/models/ability/symptom_spec.rb b/backend/spec/models/ability/symptom_spec.rb
@@ -64,7 +64,7 @@
 
     context "popular symptoms" do
       before { create_list(:user_symptom, Flaredown.config.trackables_min_popularity, symptom: popular_symptom) }
-      let(:popular_symptom_ids) { Ability.new(user).send("popular_trackable_ids", "Symptom") }
+      let(:popular_symptom_ids) { Ability.new(user).send(:popular_trackable_ids, "Symptom") }
 
       it { expect(popular_symptom_ids).to eq([popular_symptom.id]) }
     end
diff --git a/backend/spec/models/ability/treatment_spec.rb b/backend/spec/models/ability/treatment_spec.rb
@@ -64,7 +64,7 @@
 
     context "popular treatmnets" do
       before { create_list(:user_treatment, Flaredown.config.trackables_min_popularity, treatment: popular_treatment) }
-      let(:popular_treatment_ids) { Ability.new(user).send("popular_trackable_ids", "Treatment") }
+      let(:popular_treatment_ids) { Ability.new(user).send(:popular_trackable_ids, "Treatment") }
 
       it { expect(popular_treatment_ids).to eq([popular_treatment.id]) }
     end
diff --git a/backend/spec/services/collection_retriever_spec.rb b/backend/spec/services/collection_retriever_spec.rb
@@ -66,7 +66,7 @@ def occurrences_for(object_id, ids_key)
 
         before do
           today = Time.zone.today
-          (0..4).each do |i|
+          5.times do |i|
             create(
               :checkin,
               :user_id => user.id,
