Ember upgrade 2.14.0 -> 2.18.2 (#657)

* Fix livereload connection issue

* Ember v2.14.0...v2.18.2

* Set port back to 4300

* Bring back test-helper.js resolver business

* Update ember-social-share for ember-cli-babel update

* Turn off some lint rules to prevent test failures

* Use brace expansion per linter rules

* Resolve unused constants and missing ones

* Fix no function prototype extension

https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-function-prototype-extensions.md

* Disable no side effects rule for now

* Update active-model-adapter for ember-cli-bable deprecation

* Fix deprecation warning in tests

DEPRECATION: `setResolver` should be imported from `@ember/test-helpers`, but was imported from `ember-qunit` [deprecation id: ember-qunit.deprecated-reexports.setResolver]

* Update ember-cli-bourbon for babel deprecation fix

* Update emter-time-field to 0.3 for babel deprecation

* Update ember-power-select to 1.10 for babel and bunch other fixes

This is the last version before the next major release which has some
breaking changes that we may need to address

* Update ember-i18n for babel deprecation fix

Last release before it was archived. Look into migrating to ember-intl

* Update ember-simple-auth for bump in deps and misc fixes

* Make engine match what node-sass supports

node-sass complains a lot when being built against 12.22.6.
https://github.com/sass/node-sass shows that the supported version for
node-sass 7 is at least node 14 so we'll add it to the list of engines

* Use node 14 for development

* Update actions to ue matrix for new node version

* Add CI for next Node versions for fun

* Fix running tests in Node 14 and phantomJS

* Update bower to latest release

* Update node-sass to 7.0.3

* Update ember-ajax

* Add some script helpers

* Update ember-cli-sass for latest version prior to move to dartsass

Author: Tonkpils

.github/workflows/frontend.yml

@@ -10,9 +10,6 @@ on:
       - main
       - master
 
-env:
-  NODE_VERSION: 12.22.6
-
 jobs:
   changes:
     runs-on: ubuntu-latest
@@ -33,21 +30,51 @@ jobs:
               - 'frontend/**'
               - '.github/workflows/**'
 
-  test-app:
+  npm-test:
+    strategy:
+      matrix:
+        node_version: ['12.22.6', '14.21']
+    needs: changes
+    if: ${{ needs.changes.outputs.frontend == 'true' }}
+    runs-on: ubuntu-latest
+    timeout-minutes: 7
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node_version }}
+          cache: npm
+          cache-dependency-path: frontend/package-lock.json
+      - run: npm install -g npm@7.0.0
+      - run: npm install
+        working-directory: ./frontend
+      - run: npm run test
+        working-directory: ./frontend
+
+  node-next-test:
+    strategy:
+      matrix:
+        node_version: ['16', '18', '20']
     needs: changes
     if: ${{ needs.changes.outputs.frontend == 'true' }}
-    name: Test app
     runs-on: ubuntu-latest
     timeout-minutes: 7
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: ${{ env.NODE_VERSION }}
+          node-version: ${{ matrix.node_version }}
           cache: npm
           cache-dependency-path: frontend/package-lock.json
       - run: npm install -g npm@7.0.0
       - run: npm install
         working-directory: ./frontend
       - run: npm run test
         working-directory: ./frontend
+
+  test-app:
+    name: Test app
+    needs: [ npm-test ]
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "done"

docker-compose.yml

@@ -47,9 +47,10 @@ services:
       - backend
     ports:
       - 4300:4300
+      - 65535:65535
     volumes:
       - ./frontend:/app
-    command: sh -c "cd /app && rm -rfd ./dist && ./node_modules/.bin/ember serve --port 4300 --proxy http://backend:3000"
+    command: sh -c "cd /app && rm -rfd ./dist && ./node_modules/.bin/ember serve --port 4300 --proxy http://backend:3000 --live-reload-host frontend --live-reload-port 65535"
     profiles:
       - dev
   app-setup:

frontend/.eslintrc.js

@@ -4,15 +4,54 @@ module.exports = {
     ecmaVersion: 2017,
     sourceType: 'module'
   },
-  extends: 'eslint:recommended',
+  plugins: [
+    'ember'
+  ],
+  extends: [
+    'eslint:recommended',
+    'plugin:ember/recommended'
+  ],
   env: {
     browser: true
   },
   rules: {
+    'ember/new-module-imports': 'off',
+    'ember/avoid-leaking-state-in-ember-objects': 'off',
+    'ember/no-on-calls-in-components': 'off',
+    'ember/closure-actions': 'off',
+    'ember/no-side-effects': 'off',
   },
   globals: {
     d3: true,
     moment: true,
     'Pusher': true
-  }
+  },
+  overrides: [
+    // node files
+    {
+      files: [
+        'testem.js',
+        'ember-cli-build.js',
+        'config/**/*.js',
+        'lib/*/index.js'
+      ],
+      parserOptions: {
+        sourceType: 'script',
+        ecmaVersion: 2015
+      },
+      env: {
+        browser: false,
+        node: true
+      }
+    },
+
+    // test files
+    {
+      files: ['tests/**/*.js'],
+      excludedFiles: ['tests/dummy/**/*.js'],
+      env: {
+        embertest: true
+      }
+    }
+  ]
 };

frontend/Dockerfile

@@ -1,4 +1,4 @@
-FROM --platform=linux/amd64 node:12.22.6
+FROM --platform=linux/amd64 node:14.21
 
 # Force npm version 7
 RUN npm i -g npm@7
@@ -9,6 +9,9 @@ COPY package*.json bower.json .bowerrc .npmrc ./
 
 RUN npm install
 
+# May no be needed in future version of node
+ENV OPENSSL_CONF=/dev/null
+
 COPY . .
 
 CMD ["npm", "start"]

frontend/README.md

@@ -12,6 +12,7 @@ You will need the following things properly installed on your computer.
 * [Bower](http://bower.io/)
 * [Ember CLI](http://ember-cli.com/)
 * [PhantomJS](http://phantomjs.org/)
+* [Google Chrome](https://google.com/chrome/)
 
 ## Installation
 
@@ -23,7 +24,9 @@ You will need the following things properly installed on your computer.
 ## Running / Development
 
 * `ember serve`
+
 * Visit your app at [http://localhost:4300](http://localhost:4300).
+* Visit your tests at [http://localhost:4300/tests](http://localhost:4300/tests).
 
 ## Running / Development via Fastboot server
 
@@ -49,8 +52,9 @@ Specify what it takes to deploy your app.
 
 ## Further Reading / Useful Links
 
-* [ember.js](http://emberjs.com/)
-* [ember-cli](http://ember-cli.com/)
+* [ember.js](https://emberjs.com/)
+* [ember-cli](https://ember-cli.com/)
+
 * Development Browser Extensions
   * [ember inspector for chrome](https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi)
   * [ember inspector for firefox](https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/)

frontend/app/app.js

@@ -1,11 +1,9 @@
-import Ember from 'ember';
+import Application from '@ember/application';
 import Resolver from './resolver';
 import loadInitializers from 'ember-load-initializers';
 import config from './config/environment';
 
-let App;
-
-App = Ember.Application.extend({
+const App = Application.extend({
   modulePrefix: config.modulePrefix,
   podModulePrefix: config.podModulePrefix,
   Resolver

frontend/app/components/checkin/trackables-step.js

@@ -33,7 +33,7 @@ export default Component.extend(TrackablesFromType, {
     return moment(this.get('checkin.date')).isSame(new Date(), 'day');
   }),
 
-  sortedTrackeds: computed('trackeds.[]', 'trackeds.@each.position', function() {
+  sortedTrackeds: computed('trackeds.{[],@each.position}', function() {
     return this.get('trackeds').toArray().sortBy('position');
   }),
 

frontend/app/components/data-export-initiator.js

@@ -7,7 +7,7 @@ export default Component.extend({
   tagName: '',
   apiHost: ENV.apiHost,
 
-  authHeader: computed('session.data.authenticated.token', 'session.currentUser.email', function() {
+  authHeader: computed('session.{data.authenticated.token,currentUser.email}', function() {
     return `Token token="${get(this, 'session.data.authenticated.token')}", ` +
       `email="${get(this, 'session.currentUser.email')}"`;
   }),

frontend/app/components/form-field.js

@@ -7,24 +7,24 @@ export default Ember.Component.extend({
 
   model: Ember.computed.alias('parentView.for'),
 
-  shouldAlwaysBeWithinAFormForComponent: function() {
+  didInsertElement() {
     Ember.run.scheduleOnce('afterRender', () => {
       var parentView = this.get('parentView');
       var elementId = this.get('elementId');
       Ember.assert("FormFieldComponent (element ID: " + elementId + ") must have a parent view in order to yield.", parentView);
       Ember.assert("FormFieldComponent (element ID: " + elementId + ") should be inside a FormForComponent.", FormForComponent.detectInstance(parentView));
     });
-  }.on('didInsertElement'),
+  },
 
 
-  hasError: function() {
+  hasError: Ember.computed('model.errors.[]', function() {
     var ref;
     if ((ref = this.get('model.errors')) != null) {
       return ref.has(this.get('for'));
     } else {
       return false;
     }
-  }.property('model.errors.[]'),
+  }),
 
   errorClass: Ember.computed('hasError', function() {
     if (this.get('hasError')) {
@@ -34,9 +34,9 @@ export default Ember.Component.extend({
     }
   }),
 
-  errors: function() {
+  errors: Ember.computed('model.errors.[]', function() {
     var errors = this.get('model.errors');
     return errors.errorsFor(this.get('for')).mapBy('message').join(', ');
-  }.property('model.errors.[]')
+  })
 
 });

frontend/app/components/posts/activity-notification.js

@@ -31,7 +31,7 @@ export default Component.extend({
     return get(this, 'notification.kind') === 'comment' ? 'responded' : 'reacted';
   }),
 
-  fullResponse: computed('people', 'notification.kind', 'notification.notifier_username', function() {
+  fullResponse: computed('people', 'notification.{kind,notifier_username}', function() {
     if(get(this, 'notification.kind') === 'mention') {
 
       return (`<b>${get(this, 'notification.notifier_username')}</b> mentioned you in a comment` ).htmlSafe();