Reach the invoice from submission pages; use the existing print pattern

maebeale · claude · maebeale · commit 53f04d6df26c · 2026-06-17T13:55:00.000-04:00
Bulk-payment payers are emailed a link to their (public) submission page, so
the invoice needs to be reachable from there — add a "View invoice" link on
both the public bulk-payment show page and the admin form-submission page.
A bulk-payment submission's invoice is now public (gated by FormSubmission
show_invoice?), matching that the submission show page is already public by id;
the blank template stays admin-only.

Also drop the bespoke print Stimulus controller in favor of the inline
onclick="window.print();" pattern already used by sibling event views
(recipients, background, social share), and render the invoice on a neutral
public background rather than the admin blue tint.

Co-Authored-By: Claude Opus 4.8 &lt;noreply@anthropic.com&gt;
diff --git a/AGENTS.md b/AGENTS.md
@@ -71,7 +71,7 @@ This codebase (Rails 8.1)
 | Directory | Purpose |
 |---|---|
 | `app/frontend/entrypoints/` | Vite entry points (application.js, application.css) |
-| `app/frontend/javascript/controllers/` | Stimulus controllers (71) |
+| `app/frontend/javascript/controllers/` | Stimulus controllers (70) |
 | `app/frontend/javascript/rhino/` | Rich text editor customizations (mentions, grid) |
 | `app/frontend/stylesheets/` | Tailwind CSS and component styles |
 
@@ -281,7 +281,6 @@ end
 - `paginated_fields` — Client-side pagination of nested fields
 - `password_toggle` — Show/hide password fields
 - `prefetch_lazy` — Prefetch lazy-loaded content
-- `print` — Triggers the browser print dialog (used by the invoice "Download PDF" button)
 - `print_options` — Print options toggle for analytics
 - `remote_select` — AJAX-powered select dropdown
 - `reveal_section` — Expand a collapsible section and scroll to it when loaded via matching URL hash
diff --git a/app/controllers/events/invoices_controller.rb b/app/controllers/events/invoices_controller.rb
@@ -3,15 +3,20 @@ module Events
   # event's content (line item + cost); when a `submission_id` is supplied it
   # autofills the bill-to/attention from that bulk-payment submission.
   class InvoicesController < ApplicationController
+    # Bulk-payment payers have no account; authorization (below) gates access.
+    skip_before_action :authenticate_user!, only: [ :show ]
     before_action :set_event
 
     def show
-      authorize! @event, to: :invoice?
-
       if params[:submission_id].present?
+        # A bulk-payment submission's invoice is reachable by the payer (who has
+        # no account), matching the public bulk-payment show page they're sent.
         @submission = FormSubmission.find(params[:submission_id])
+        authorize! @submission, to: :show_invoice?
         @invoice = EventInvoice.from_bulk_payment(@submission)
       else
+        # The blank template is an admin tool.
+        authorize! @event, to: :invoice?
         @invoice = EventInvoice.from_event(@event)
       end
 
diff --git a/app/frontend/javascript/controllers/index.js b/app/frontend/javascript/controllers/index.js
@@ -117,9 +117,6 @@ application.register("search-type-select", SearchTypeSelectController)
 import PrefetchLazyController from "./prefetch_lazy_controller"
 application.register("prefetch-lazy", PrefetchLazyController)
 
-import PrintController from "./print_controller"
-application.register("print", PrintController)
-
 import PrintOptionsController from "./print_options_controller"
 application.register("print-options", PrintOptionsController)
 
diff --git a/app/frontend/javascript/controllers/print_controller.js b/app/frontend/javascript/controllers/print_controller.js
diff --git a/app/policies/form_submission_policy.rb b/app/policies/form_submission_policy.rb
@@ -3,4 +3,11 @@ class FormSubmissionPolicy < ApplicationPolicy
   def show?
     admin?
   end
+
+  # Bulk-payment payers have no account but are emailed a link to their public
+  # submission, so they can reach its invoice too. Other submission types stay
+  # admin-only.
+  def show_invoice?
+    record.role == "bulk_payment" || admin?
+  end
 end
diff --git a/app/views/events/_bulk_payment_card.html.erb b/app/views/events/_bulk_payment_card.html.erb
@@ -40,7 +40,7 @@
                   class: "inline-flex items-center gap-1.5 rounded-lg border border-gray-300 bg-white px-2.5 py-1 text-xs font-medium text-gray-600 shadow-sm hover:bg-gray-50 hover:text-gray-800 transition-colors whitespace-nowrap" do %>
         <i class="fa-solid fa-file-lines text-xs"></i> Submission
       <% end %>
-      <%= link_to event_invoice_path(@event, submission_id: submission.id),
+      <%= link_to event_invoice_path(@event, submission_id: submission.id, return_to: "bulk_payments"),
                   title: "View invoice",
                   class: "inline-flex items-center gap-1.5 rounded-lg border border-gray-300 bg-white px-2.5 py-1 text-xs font-medium text-gray-600 shadow-sm hover:bg-gray-50 hover:text-gray-800 transition-colors whitespace-nowrap" do %>
         <i class="fa-solid fa-file-invoice-dollar text-xs"></i> Invoice
diff --git a/app/views/events/bulk_payments/show.html.erb b/app/views/events/bulk_payments/show.html.erb
@@ -45,6 +45,13 @@
       <% end %>
       <%= render "form_submissions/submission", submission: @submission %>
 
+      <div class="mt-6 flex justify-center">
+        <%= link_to event_invoice_path(@event, submission_id: @submission.id, return_to: "bulk_payment_show"),
+                    class: "inline-flex items-center gap-2 rounded-lg border border-gray-300 bg-white px-4 py-2 text-sm font-medium text-gray-700 shadow-sm hover:bg-gray-50 transition-colors" do %>
+          <i class="fa-solid fa-file-invoice-dollar"></i> View invoice
+        <% end %>
+      </div>
+
       <% if allowed_to?(:dashboard?, @event) %>
         <div class="admin-only mt-6 rounded-lg border border-blue-200 bg-blue-50/50 px-4 py-4 space-y-3">
           <div class="flex items-center justify-between gap-2">
diff --git a/app/views/events/invoices/_actions.html.erb b/app/views/events/invoices/_actions.html.erb
@@ -5,10 +5,8 @@
   <%= link_to back_path, class: "inline-flex items-center gap-1.5 text-sm text-gray-500 hover:text-gray-700 px-2 py-1" do %>
     <i class="fa-solid fa-arrow-left text-xs"></i> <%= back_label %>
   <% end %>
-  <div class="ml-auto" data-controller="print">
-    <button type="button" data-action="print#print"
-            class="inline-flex items-center gap-2 rounded-lg border border-gray-300 bg-white px-3 py-2 text-sm font-medium text-gray-700 shadow-sm hover:bg-gray-50 transition-colors">
-      <i class="fa-solid fa-file-arrow-down"></i> Download PDF
-    </button>
-  </div>
+  <button onclick="window.print();"
+          class="ml-auto inline-flex items-center gap-2 rounded-lg border border-gray-300 bg-white px-3 py-2 text-sm font-medium text-gray-700 shadow-sm hover:bg-gray-50 transition-colors">
+    <i class="fa-solid fa-file-arrow-down"></i> Download PDF
+  </button>
 </div>
diff --git a/app/views/events/invoices/show.html.erb b/app/views/events/invoices/show.html.erb
@@ -1,14 +1,21 @@
-<% content_for(:page_bg_class, "admin-only bg-blue-100") %>
+<% content_for(:page_bg_class, "public") %>
 <% content_for(:page_title, "Invoice — #{@event.title}") %>
-<% if @submission %>
-  <%= render "events/invoices/actions",
-        back_path: bulk_payments_event_path(@event, expand: @submission.id, anchor: "payment-card-#{@submission.id}"),
-        back_label: "Back to bulk payments" %>
-<% else %>
-  <%= render "events/invoices/actions",
-        back_path: dashboard_event_path(@event),
-        back_label: "Back to event" %>
-<% end %>
+<%
+  back_path, back_label =
+    if @submission
+      case params[:return_to]
+      when "bulk_payment_show"
+        [ event_bulk_payment_path(@event, submission_id: @submission.id), "Back to submission" ]
+      when "form_submission"
+        [ form_submission_path(@submission), "Back to submission" ]
+      else
+        [ bulk_payments_event_path(@event, expand: @submission.id, anchor: "payment-card-#{@submission.id}"), "Back to bulk payments" ]
+      end
+    else
+      [ dashboard_event_path(@event), "Back to event" ]
+    end
+%>
+<%= render "events/invoices/actions", back_path: back_path, back_label: back_label %>
 <div class="px-4 sm:px-8 py-6 print:p-0">
   <%= render "events/invoices/invoice", invoice: @invoice %>
 </div>
diff --git a/app/views/form_submissions/show.html.erb b/app/views/form_submissions/show.html.erb
@@ -29,6 +29,15 @@
     </div>
     <div class="px-6 sm:px-8 py-7">
       <%= render "form_submissions/submission", submission: @form_submission %>
+
+      <% if event && @form_submission.role == "bulk_payment" %>
+        <div class="mt-6 flex justify-center">
+          <%= link_to event_invoice_path(event, submission_id: @form_submission.id, return_to: "form_submission"),
+                      class: "inline-flex items-center gap-2 rounded-lg border border-gray-300 bg-white px-4 py-2 text-sm font-medium text-gray-700 shadow-sm hover:bg-gray-50 transition-colors" do %>
+            <i class="fa-solid fa-file-invoice-dollar"></i> View invoice
+          <% end %>
+        </div>
+      <% end %>
     </div>
   </div>
 </div>
diff --git a/spec/requests/events/bulk_payments_spec.rb b/spec/requests/events/bulk_payments_spec.rb
@@ -209,6 +209,13 @@ def get_show
         expect(response).to have_http_status(:ok)
         expect(response.body).not_to include("Payment allocations")
       end
+
+      it "links to the submission's invoice" do
+        get_show
+
+        expect(response.body).to include("/events/#{event.id}/invoice")
+        expect(response.body).to include("submission_id=#{submission.id}")
+      end
     end
   end
 end
diff --git a/spec/requests/events/invoices_spec.rb b/spec/requests/events/invoices_spec.rb
@@ -49,7 +49,29 @@ def add_answer(identifier, value)
     context "as a non-admin" do
       before { sign_in create(:user) }
 
-      it "is denied and redirected" do
+      it "is denied the blank template and redirected" do
+        get event_invoice_path(event)
+        expect(response).to redirect_to(root_path)
+      end
+    end
+
+    context "as a guest (no account)" do
+      let(:form) { create(:form) }
+      let!(:submission) { create(:form_submission, form: form, event: event, role: "bulk_payment") }
+
+      it "can view a bulk-payment submission's invoice (matches the public show page)" do
+        get event_invoice_path(event, submission_id: submission.id)
+        expect(response).to have_http_status(:success)
+        expect(response.body).to include("INVOICE")
+      end
+
+      it "is denied an invoice for a non-bulk submission" do
+        other = create(:form_submission, form: form, event: event, role: "registration")
+        get event_invoice_path(event, submission_id: other.id)
+        expect(response).to redirect_to(root_path)
+      end
+
+      it "is still denied the blank template" do
         get event_invoice_path(event)
         expect(response).to redirect_to(root_path)
       end
