Remove "Other" payment method entirely

Rather than keeping "Other" in code and hiding it, drop it as a payment
option altogether: remove it from the form builder's options, delete the
view filters that hid it, and add a data migration to strip it from
existing payment_method fields (the shared "Other" AnswerOption is left
intact for other fields).

Scholarship applicants previously used "Other" as their payment method.
Since they are requesting assistance rather than choosing how to pay, the
payment section is now hidden for scholarship requests, mirroring how it
is already dropped for free events.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: maebeale

app/controllers/events/public_registrations_controller.rb

@@ -18,9 +18,9 @@ def new
         return
       end
 
-      @form_fields = visible_form_fields
       @scholarship = scholarship_mode?
       @scholarship_form = @event.scholarship_form if @scholarship
+      @form_fields = visible_form_fields
       @event = @event.decorate
     end
 
@@ -271,7 +271,10 @@ def visible_form_fields
         end
       end
 
-      if @event.cost_cents.to_i <= 0
+      # Free events have nothing to pay, and scholarship applicants are asking for
+      # assistance rather than choosing a payment method, so the payment section is
+      # dropped in both cases.
+      if @event.cost_cents.to_i <= 0 || @scholarship
         payment_field_ids = @form.form_fields.where(field_identifier: "payment_method").ids
         if payment_field_ids.any?
           scope = scope.where.not(id: payment_field_ids)

app/services/form_builder_service.rb

@@ -3,12 +3,7 @@ class FormBuilderService
   # charge, so controllers match against PAYMENT_METHOD_PAY_NOW rather than
   # repeating its label. Keep this the single source of truth for the label.
   PAYMENT_METHOD_PAY_NOW = "Credit card (now)".freeze
-  # "Other" is retained as a payment method in code and form data — the scholarship
-  # flow stores it as the payment method — but it is intentionally hidden from the
-  # options surfaced on public forms for now (see the public registration and bulk
-  # payment views, which filter it out).
-  PAYMENT_METHOD_OTHER = "Other".freeze
-  PAYMENT_METHOD_OPTIONS = [ PAYMENT_METHOD_PAY_NOW, "Credit card (later)", "Check", PAYMENT_METHOD_OTHER ].freeze
+  PAYMENT_METHOD_OPTIONS = [ PAYMENT_METHOD_PAY_NOW, "Credit card (later)", "Check" ].freeze
 
   SECTIONS = {
     person_identifier: { label: "Person identifier", method: :build_person_identifier_fields },

app/views/events/bulk_payments/new.html.erb

@@ -134,8 +134,7 @@
                     <% if field.required %><span class="text-red-500">*</span><% end %>
                   </label>
                   <div class="flex flex-wrap gap-2 mt-1">
-                    <%# "Other" is kept in code/data but hidden on the form for now. %>
-                    <% field.form_field_answer_options.includes(:answer_option).reject { |ffao| ffao.answer_option.name == FormBuilderService::PAYMENT_METHOD_OTHER }.each do |ffao| %>
+                    <% field.form_field_answer_options.includes(:answer_option).each do |ffao| %>
                       <label class="inline-flex items-center gap-2 rounded-lg border <%= error ? 'border-red-400' : 'border-gray-300' %> px-3 py-2.5 cursor-pointer hover:border-blue-400 has-[:checked]:border-blue-600 has-[:checked]:bg-blue-50 transition">
                         <input type="radio"
                                name="bulk_payment[form_fields][<%= field.id %>]"

app/views/events/public_registrations/_form_field.html.erb

@@ -72,12 +72,6 @@
         data and store none of their own, so fall back to those when present. %>
     <% radio_options = dynamic_form_field_options(field) ||
          field.form_field_answer_options.includes(:answer_option).map { |ffao| [ ffao.answer_option.name, ffao.answer_option.name ] } %>
-    <%# "Other" is hidden on the payment method field for now (it stays in code/data
-        for the scholarship flow). Keep it only when it's already the selected value
-        so a preset/stored "Other" still renders checked. %>
-    <% if field.field_identifier == "payment_method" %>
-      <% radio_options = radio_options.reject { |_option_label, option_value| option_value == FormBuilderService::PAYMENT_METHOD_OTHER && value != FormBuilderService::PAYMENT_METHOD_OTHER } %>
-    <% end %>
     <% has_specify = radio_options.any? { |option_label, _option_value| specify_placeholder(option_label).present? } %>
     <%= tag.div class: "flex flex-wrap gap-2.5 mt-1", data: (has_specify ? { controller: "specify-option", action: "change->specify-option#update" } : {}) do %>
       <% radio_options.each do |option_label, option_value, option_description| %>

app/views/events/public_registrations/new.html.erb

@@ -122,7 +122,7 @@
             <% else %>
               <% submitted_value = params.dig(:public_registration, :form_fields, field.id.to_s) %>
               <% if submitted_value.blank? && field.field_identifier == "payment_method" %>
-                <% submitted_value = @scholarship ? FormBuilderService::PAYMENT_METHOD_OTHER : FormBuilderService::PAYMENT_METHOD_PAY_NOW %>
+                <% submitted_value = FormBuilderService::PAYMENT_METHOD_PAY_NOW %>
               <% end %>
               <div class="<%= field.grid_span_class %>">
                 <%= render "events/public_registrations/form_field", field: field, value: submitted_value, label: email_label_overrides[field.field_identifier] %>

db/migrate/20260617120000_remove_other_payment_method_option.rb

@@ -0,0 +1,36 @@
+class RemoveOtherPaymentMethodOption < ActiveRecord::Migration[8.0]
+  # The "Other" payment method has been removed from the form builder's options.
+  # Existing payment_method fields still carry it as a stored answer option, so
+  # drop those join rows. The "Other" AnswerOption record is shared across many
+  # fields (sectors, colors, etc.), so it is left intact — only the payment
+  # associations are removed.
+  def up
+    execute(<<~SQL.squish)
+      DELETE FROM form_field_answer_options
+      WHERE answer_option_id IN (SELECT id FROM answer_options WHERE name = 'Other')
+        AND form_field_id IN (SELECT id FROM form_fields WHERE field_identifier = 'payment_method')
+    SQL
+  end
+
+  def down
+    # Re-attach "Other" to every payment_method field that no longer has it,
+    # reusing the shared AnswerOption (creating it only if it is missing).
+    execute(<<~SQL.squish)
+      INSERT INTO answer_options (name, created_at, updated_at)
+      SELECT 'Other', NOW(), NOW()
+      WHERE NOT EXISTS (SELECT 1 FROM answer_options WHERE name = 'Other')
+    SQL
+
+    execute(<<~SQL.squish)
+      INSERT INTO form_field_answer_options (form_field_id, answer_option_id, created_at, updated_at)
+      SELECT ff.id, ao.id, NOW(), NOW()
+      FROM form_fields ff
+      CROSS JOIN (SELECT id FROM answer_options WHERE name = 'Other' LIMIT 1) ao
+      WHERE ff.field_identifier = 'payment_method'
+        AND NOT EXISTS (
+          SELECT 1 FROM form_field_answer_options ffao
+          WHERE ffao.form_field_id = ff.id AND ffao.answer_option_id = ao.id
+        )
+    SQL
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[8.1].define(version: 2026_06_16_130000) do
+ActiveRecord::Schema[8.1].define(version: 2026_06_17_120000) do
   create_table "action_text_mentions", charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t|
     t.bigint "action_text_rich_text_id", null: false
     t.datetime "created_at", null: false

spec/requests/events/public_registrations_spec.rb

@@ -455,17 +455,22 @@ def post_with_scholarship(scholarship_answer)
       field
     end
 
-    it "hides the 'Other' payment method from a normal registrant" do
+    it "does not offer 'Other' as a payment method" do
+      expect(FormBuilderService::PAYMENT_METHOD_OPTIONS).not_to include("Other")
+    end
+
+    it "renders the remaining payment methods without 'Other'" do
       get new_event_public_registration_path(event)
 
       expect(response.body).to include(%(value="Check"))
       expect(response.body).not_to include(%(value="Other"))
     end
 
-    it "keeps 'Other' as the preselected payment method for a scholarship registrant" do
+    it "hides the payment method entirely for a scholarship registrant" do
       get new_event_public_registration_path(event, scholarship_requested: "true")
 
-      expect(response.body).to match(/value="Other"[^>]*\bchecked\b/)
+      expect(response.body).not_to include("Payment method")
+      expect(response.body).not_to include(%(value="Check"))
     end
   end