Remove obsolete POST search endpoints for workshops and resources (#1035)

* Initial plan

* Remove old workshops and resources search endpoints and Search class

Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>

Author: Copilot

app/assets/javascripts/components/side_nav.js

@@ -45,9 +45,6 @@ function setActiveMenuItem() {
         link = $('.js-resources');
       }
       break;
-    case '/resources/search':
-      link = $('.js-resources');
-      break;
     case '/resources/' + digit(path):
       link = $('.js-resources');
       break;
@@ -61,9 +58,6 @@ function setActiveMenuItem() {
     case '/workshops/' + digit(path):
       link = $('.js-search');
       break;
-    case '/workshops/search':
-      link = $('.js-search');
-      break;
     case '/workshops/new':
     case '/workshop_logs/new':
       subMenu = $('.js-report');

app/controllers/resources_controller.rb

@@ -121,13 +121,6 @@ def destroy
     redirect_to resources_path, notice: "Resource was successfully destroyed."
   end
 
-  def search
-    authorize!
-    process_search
-    @sortable_fields = Resource::PUBLISHED_KINDS
-    render :index
-  end
-
   def download
     @resource = Resource.find(params[:resource_id])
     authorize! @resource
@@ -180,12 +173,6 @@ def assign_associations(resource)
     resource.save!
   end
 
-  def process_search
-    @params = search_params
-    @query = search_params[:query]
-    @resources = Search.new.search(search_params, current_user).paginate(page: params[:search][:page])
-  end
-
   def resource_id_param
     params[:id]
   end
@@ -211,8 +198,4 @@ def load_forms
       end
     end
   end
-
-  def search_params
-    params[:search]
-  end
 end

app/controllers/workshops_controller.rb

@@ -173,25 +173,6 @@ def update
   end
 
 
-  def search
-    @params = params[:search]
-    @query = params[:search][:query] if @params
-    @workshops = Search.new.search(@params, current_user)
-
-    if @workshops.paginate(page: params[:search][:page], per_page: workshops_per_page).empty?
-      @workshops = @workshops.paginate(page: 1, per_page: workshops_per_page)
-    else
-      @workshops = @workshops.paginate(page: params[:search][:page], per_page: workshops_per_page)
-    end
-
-    authorize! @workshops
-
-    load_sortable_fields
-    load_metadata
-
-    render :index
-  end
-
   private
 
   def set_show
@@ -241,14 +222,6 @@ def log_workshop_error(action, error)
     Rails.logger.error "Workshop #{action} failed: #{error.class} - #{error.message}\n#{error.backtrace.join("\n")}"
   end
 
-  def workshops_per_page
-    view_all_workshops? ? @workshops.published.size : 12
-  end
-
-  def view_all_workshops?
-    params[:search][:view_all] == "1"
-  end
-
   def workshop_params
     params.require(:workshop).permit(
       :title, :featured, :published,
@@ -323,12 +296,4 @@ def workshop_params
                                             :position, :_destroy ]
     )
   end
-
-  def load_sortable_fields
-    @sortable_fields = WindowsType.where(short_name: "COMBINED")
-  end
-
-  def load_metadata
-    @metadata = CategoryType.includes(:categories).published.decorate
-  end
 end

app/services/search.rb

@@ -116,9 +116,6 @@
 
   resources :resources do
     get :download
-    collection do
-      post :search
-    end
   end
   resources :sectors do
     collection do
@@ -145,11 +142,7 @@
   resources :workshop_log_creation_wizard
   resources :workshop_variation_ideas
   resources :workshop_variations
-  resources :workshops do
-    collection do
-      post :search
-    end
-  end
+  resources :workshops
 
   resources :workshop_mentions, only: [ :index ]
   resources :resource_mentions, only: [ :index ]