Remove obsolete POST search endpoints for workshops and resources

[Copilot]

What is the goal of this PR and why is this important?

Remove old search code that we're not using anymore.

The codebase has migrated to Turbo Frame-based search but retained obsolete POST endpoints (/workshops/search, /resources/search) and their supporting infrastructure. This PR removes 136 lines of dead code.

How did you approach the change?

Removed unused code paths:

• Service layer: Deleted app/services/search.rb - legacy search class only referenced by removed actions
• Controllers: Removed search actions and supporting methods (workshops_per_page, view_all_workshops?, load_sortable_fields, load_metadata, process_search, search_params)
• Routes: Removed post :search collection routes for both resources
• Frontend: Cleaned up obsolete path references in side_nav.js

Modern equivalents already in use:

• Workshops: WorkshopSearchService invoked by index action
• Resources: search_by_params scope with Turbo frame rendering

Anything else to add?

No forms POST to these endpoints. Existing system tests validate the current Turbo-based approach.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[maebeale]

@copilot were there any views? or things in decorators that were used only in search?

[Copilot]

@copilot were there any views? or things in decorators that were used only in search?

Good catch! I found one unused decorator method:

ResourcesDecorator.search_page (app/decorators/resources_decorator.rb) - references params[:search][:page] but was never actually used because:

• The old search action didn't decorate the collection (only individual resources get decorated in this controller)
• No views reference this method

Views: Both old search actions rendered the :index view which now uses Turbo frames exclusively. The index views don't depend on any of the removed variables (@sortable_fields, @metadata, @query).

Should I remove the unused search_page method from ResourcesDecorator?