Skip to content

Load full dev seeds in Conductor workspaces via --seed-dev#1588

Merged
maebeale merged 1 commit into
mainfrom
maebeale/conductor-seed-dev
Jun 7, 2026
Merged

Load full dev seeds in Conductor workspaces via --seed-dev#1588
maebeale merged 1 commit into
mainfrom
maebeale/conductor-seed-dev

Conversation

@maebeale

@maebeale maebeale commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

What is the goal of this PR and why is this important?

How did you approach the change?

  • Added a --seed-dev flag to bin/setup: when present it runs db:seed:dev (which chains the base db:seed first); otherwise it stays on plain db:seed so CI and lean setups are unaffected
  • Pass --seed-dev from bin/conductor-setup, since Conductor workspaces are always dev
  • Dropped the redundant npm ci from bin/conductor-setup (bin/setup already runs it) and clarified the surrounding comment

Anything else to add?

  • Existing workspaces won't backfill automatically — run bin/rails db:seed:dev once to populate, or re-run setup
  • db:seed:dev is dev-only by design; the default db:seed path is preserved for production-style and CI runs

bin/setup hardcoded `db:seed`, so Conductor workspaces only ever got the
minimal base seeds and the UI came up empty of sample data. The dev sample
set (workshops, events, analytics, profiles, payments, etc.) lives behind
the `db:seed:dev` rake task, which nothing was invoking.

Add a `--seed-dev` flag to bin/setup that swaps in `db:seed:dev` (it chains
the base `db:seed` first), keeping plain `db:seed` the default for CI and
lean setups, and pass it from bin/conductor-setup since Conductor
workspaces are always dev.

Also drops the redundant `npm ci` from bin/conductor-setup — bin/setup
already runs it — and clarifies the surrounding comment.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@maebeale maebeale marked this pull request as ready for review June 7, 2026 03:28
Comment thread bin/setup
# --seed-dev loads the full dev sample dataset (db:seed:dev chains the base
# db:seed first); plain db:seed stays the default for CI and lean setups.
if ARGV.include?("--seed-dev")
system! "bin/rails db:seed:dev"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 From Claude: db:seed:dev chains the base db:seed first, so this branch swaps the call rather than running both. Plain db:seed stays the default so CI and production-style setups skip the dev sample data.

@maebeale maebeale merged commit c610683 into main Jun 7, 2026
5 of 7 checks passed
@maebeale maebeale deleted the maebeale/conductor-seed-dev branch June 7, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant