Add sector descriptions and refresh the canonical sector list#1703
Merged
Conversation
Sectors gain an optional description so a service area can carry a short clarification, the way categories already do. On the public registration form the description shows as subtext under each checkbox in the additional service-areas list, and is folded into a "Name (description)" label in the single primary service-area dropdown, which can't show subtext. The canonical SECTOR_TYPES list is refreshed to the current service-area tags, with the parenthetical clarifications moved into seeded descriptions. Sectors no longer on the list are unpublished rather than destroyed, preserving historical taggings; the "Other" catch-all stays published. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 17, 2026
| # taggings rather than destroying them. SECTOR_TYPES already includes the "Other" | ||
| # catch-all, so it stays published. | ||
| canonical_names = Sector::SECTOR_TYPES.map(&:downcase) | ||
| Sector.reject { |sector| canonical_names.include?(sector.name.downcase) } |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Sectors dropped from the canonical list are unpublished here, not destroyed, so historical taggings survive. Other stays published because it's the free-text catch-all for additional service areas, not a selectable tag.
maebeale
commented
Jun 17, 2026
| <% dropdown_options.each do |option_label, option_value| %> | ||
| <option value="<%= option_value %>" <%= "selected" if value == option_value %>><%= option_label %></option> | ||
| <%# A dropdown can't show subtext, so an option's description is folded into | ||
| the label as "Name (description)". %> |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: A dropdown can't show subtext, so a sector/category description is folded into the label as "Name (description)" here; the checkbox/radio renderers instead show it as gray subtext under the option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
descriptioncolumn toSector(migration + admin form, show, and index, mirroring the category pattern) and surfaced it on the public registration form: as subtext under each checkbox in the additional service-areas list, and folded into aName (description)label in the single primary service-area dropdown (which can't show subtext).SECTOR_TYPESto the current tags, moved the parenthetical clarifications into seeded descriptions, and made seeding unpublish sectors no longer on the list (preserving historical taggings) while keeping theOthercatch-all published.UI Testing Checklist
Name (description).Anything else to add?
Systems/Policy Change(was "Sytems") and the Climate/Environmental descriptionenvironmental trauma(was "envirnomental"). Flagging in case either was intentional.