Skip to content

Remove "Other" payment method from registration forms#1706

Merged
maebeale merged 2 commits into
mainfrom
maebeale/hide-other-payment-type
Jun 17, 2026
Merged

Remove "Other" payment method from registration forms#1706
maebeale merged 2 commits into
mainfrom
maebeale/hide-other-payment-type

Conversation

@maebeale

@maebeale maebeale commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

What is the goal of this PR and why is this important?

  • The "Other" payment method added noise to the payment choice without a clear meaning for registrants, so it is being removed from the registration and bulk payment forms.

How did you approach the change?

  • Dropped "Other" from FormBuilderService::PAYMENT_METHOD_OPTIONS, so newly built registration and bulk payment forms no longer offer it. Existing forms are left as-is (no data migration).
  • Scholarship applicants previously had "Other" preselected as their payment method; they now see the same default as every other registrant and are still never charged.

UI Testing Checklist

  • On a paid event's registration form, the payment method choices show Credit card (now/later) and Check, with no "Other".
  • On the bulk payment form, "Other" no longer appears among the payment method choices.
  • A scholarship registration still shows the payment method section (without "Other").

Anything else to add?

  • Added request specs covering the removed option and the scholarship behavior.

@maebeale maebeale requested a review from jmilljr24 June 17, 2026 17:36

@jmilljr24 jmilljr24 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think this is the direction it needs to go that is fine.

My understand from the conversation was to remove "other" completely. They will get user feedback on any confusion regarding scholarships and payments.

One down side to this is we now have another option of a hardcoded value with extra logic around it. I don't love having the stripe checkout dependent on a string (we already saw the issue of checkouts not working with this). My vote it so just remove other. One less thing to deal with right now.

@maebeale maebeale changed the title Hide "Other" payment method on registration forms Remove "Other" payment method from registration forms Jun 17, 2026
The "Other" option offered no clear meaning to registrants and added
noise to the payment choice. Keep it in code and form data — the
scholarship flow still relies on it as the stored payment method — but
filter it out of the options surfaced on the public registration and
bulk payment forms, preserving it only when it's already the selected
value (e.g. the scholarship preset).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@maebeale maebeale force-pushed the maebeale/hide-other-payment-type branch from 89af800 to 957fe77 Compare June 17, 2026 18:13
The "Other" option offered no clear meaning to registrants and added
noise to the payment choice, so drop it from the form builder's payment
method options. New registration and bulk payment forms no longer offer
it; existing forms are left as-is.

Scholarship applicants previously had "Other" preselected; they now see
the same default as everyone else, and are still never charged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@maebeale maebeale force-pushed the maebeale/hide-other-payment-type branch from 957fe77 to 091beb5 Compare June 17, 2026 18:22
@maebeale

Copy link
Copy Markdown
Collaborator Author

ok updated to just remove

@maebeale maebeale merged commit defcbda into main Jun 17, 2026
3 checks passed
@maebeale maebeale deleted the maebeale/hide-other-payment-type branch June 17, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants