Skip to content

Commit 1916263

Browse files
authored
Merge pull request #6708 from hexdevs/sb-upgrade-node-to-v24
Upgrade node to v24
2 parents c860007 + 3a1fcdc commit 1916263

8 files changed

Lines changed: 10 additions & 11 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"version": "latest"
2626
},
2727
"ghcr.io/devcontainers/features/node:1": {
28-
"version": "22.11.0"
28+
"version": "24.13.0"
2929
}
3030
},
3131

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
lts/jod
1+
lts/krypton

.tool-versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
ruby 3.3.8
2-
nodejs 22.11.0
2+
nodejs 24.13.0

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ FROM ruby:3.3.8-alpine
2121

2222
ARG RAILS_ROOT=/usr/src/app/
2323

24+
RUN apk add --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/main/ nodejs=24.13.0-r2 npm
25+
2426
# available: https://pkgs.alpinelinux.org/packages
2527
RUN apk update && apk upgrade && apk add --update --no-cache \
2628
bash \
2729
build-base \
2830
curl \
2931
imagemagick \
30-
nodejs \
31-
npm \
3232
postgresql-client \
3333
tzdata \
3434
vim \

app/javascript/src/validated_form.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ $(() => { // JQuery's callback for the DOM loading
253253
if ($('#case_contact_miles_driven').length) {
254254
safeInstantiateComponent('non driving contact medium warning', () => {
255255
const contactMediumWithMilesDrivenWarning = new NonDrivingContactMediumWarning(validatedFormCollection.find('.contact-medium.form-group input:not([type=hidden]), #case_contact_miles_driven'), pageNotifier)
256-
console.log(contactMediumWithMilesDrivenWarning)
257256
validatableFormSectionComponents.push(contactMediumWithMilesDrivenWarning)
258257
})
259258
}

doc/LINUX_SETUP.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ sudo -u postgres psql -c "CREATE USER $USER WITH CREATEDB"
5454
```
5555
# Install NVM and Node JS
5656
# you can use curl
57-
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
57+
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.4/install.sh | bash
5858
# or wget
59-
wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
59+
wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.4/install.sh | bash
6060
6161
# Restart your terminal
6262
@@ -71,7 +71,7 @@ npm i -g npm@latest
7171

7272
```
7373
# add node and node tools to the path
74-
nvm alias default lts/jod
74+
nvm alias default lts/krypton
7575
```
7676

7777
```

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,6 @@
6666
]
6767
},
6868
"engines": {
69-
"node": "22.x"
69+
"node": "24.x"
7070
}
7171
}

0 commit comments

Comments
 (0)