Skip to content

Commit 1b643cb

Browse files
marcorothcompwron
marcoroth
authored and
compwron
committed
Address HTML markup issues reported by Herb
1 parent 8399953 commit 1b643cb

21 files changed

Lines changed: 55 additions & 55 deletions

‎app/views/casa_cases/_court_dates.html.erb‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<% else %>
66
<ul>
77
<% court_dates.each do |pcd| %>
8-
<p>
8+
<li>
99
<div class="court-date-row">
1010
<%= link_to(pcd.decorate.court_date_info, casa_case_court_date_path(casa_case, pcd), class: "court-date-link") %>
1111
<%= render 'calendar_button',
@@ -22,7 +22,7 @@
2222
(Attached Report)
2323
<% end %>
2424
<% end %>
25-
</p>
25+
</li>
2626
<% end %>
2727
</ul>
2828
<% end %>

‎app/views/casa_cases/show.html.erb‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,24 +37,24 @@
3737
<% if !@casa_case.active %>
3838
<%= render "inactive_case", casa_case: @casa_case %>
3939
<% end %>
40-
<p>
40+
<div>
4141
<h6><strong>Case number:</strong> <%= @casa_case.case_number %>
4242
<%= volunteer_badge(@casa_case, current_user) %>
4343
</h6>
44-
</p>
44+
</div>
4545
<% if @casa_case.hearing_type %>
46-
<p>
46+
<div>
4747
<h6><strong>Hearing Type:</strong> <%= @casa_case.hearing_type_name %></h6>
48-
</p>
48+
</div>
4949
<% end %>
5050
<% if @casa_case.has_judge_name? %>
51-
<p>
51+
<div>
5252
<h6><strong>Judge:</strong> <%= @casa_case.judge_name %></h6>
53-
</p>
53+
</div>
5454
<% end %>
55-
<p>
55+
<div>
5656
<h6><strong>Transition Aged Youth:</strong> <%= @casa_case.decorate.transition_aged_youth %></h6>
57-
</p>
57+
</div>
5858
<div>
5959
<h6>
6060
<strong>
@@ -64,7 +64,7 @@
6464
<%= @casa_case.decorate.duration_in_care %>
6565
</h6>
6666
</div>
67-
<p>
67+
<div>
6868
<h6>
6969
<strong>Next Court Date:</strong>
7070
<%= I18n.l(@casa_case.next_court_date&.date, format: :day_and_date, default: '') %>
@@ -73,22 +73,22 @@
7373
tooltip: "Add Next Court Date to Calendar",
7474
title: "Next Court Date for [#{@casa_case.case_number}]" %>
7575
</h6>
76-
</p>
77-
<p>
76+
</div>
77+
<div>
7878
<h6>
7979
<strong>Court Report Status:</strong>
8080
<%= @casa_case.decorate.court_report_submission %></h6>
81-
</p>
81+
</div>
8282
<% unless @casa_case.court_report_not_submitted? %>
8383
<% if @casa_case.court_report_submitted? && @casa_case.court_reports.attached? %>
8484
<%= link_to('Click to download',
8585
rails_blob_path(@casa_case.latest_court_report, disposition: 'attachment')) %>
8686
<% end %>
87-
<p>
87+
<div>
8888
<h6>
8989
<strong>Court Report Submitted Date:</strong>
9090
<%= @casa_case.decorate.court_report_submitted_date %></h6>
91-
</p>
91+
</div>
9292
<% end %>
9393
<% if @casa_case.case_court_orders.exists? %>
9494
<h6><strong>Court Orders:</strong></h6>

‎app/views/casa_org/_languages.html.erb‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,4 @@
4545
</div>
4646
</div>
4747
</div>
48+
</div>

‎app/views/case_contacts/_confirm_note_content_dialog.html.erb‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
</div>
77
<div class="modal-body">
88
Please double check your notes to ensure they don't contain any identifying details about your youth or anyone else.
9-
<p class="mt-3">
9+
<div class="mt-3">
1010
<h6>Note</h6>
1111
<div id="note-content"></div>
12-
</p>
12+
</div>
1313
</div>
1414

1515
<div class="modal-footer justify-content-between">

‎app/views/devise/invitations/edit.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
type: "submit",
2323
class: "main-btn primary-btn btn-hover btn-sm"
2424
) do %>
25-
<i class="lni lni-lock-alt mr-10"></i></i>Set my password
25+
<i class="lni lni-lock-alt mr-10"></i>Set my password
2626
<% end %>
2727
</div>
2828
<% end %>

‎app/views/devise/sessions/new.html.erb‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@
6666
) do %>
6767
<i class="lni lni-chevron-right-circle mr-10"></i>Log In
6868
<% end %>
69+
</div>
70+
</div>
6971
<% end %>
7072
<div class="col-xxl-6 col-lg-12 col-md-6">
7173
<div class="text-start text-md-end text-lg-start text-xxl-end mb-30">
7274
</div>
7375
</div>
7476
<div class="col-xxl-6 col-lg-12 col-md-6">
7577
</div>
76-
</div>
77-
</div>
7878
</div>
7979
</div>
8080
</div>

‎app/views/emancipations/show.html.erb‎

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@
1818
<% @emancipation_form_data.each do |category| %>
1919
<h6 class="emancipation-category no-select" data-is-open="<%= emancipation_category_checkbox_checked(@current_case, category) ? "true" : "false" %>">
2020
<div class="checkbox-style emacipation-category-input-label-pair">
21-
<input
22-
type="checkbox"
23-
class="emancipation-category-check-box form-check-input"
24-
value="<%= category.id %>"
25-
<%= emancipation_category_checkbox_checked(@current_case, category) %>>
21+
<%= input_tag(
22+
type: "checkbox",
23+
class: "emancipation-category-check-box form-check-input",
24+
value: category.id,
25+
disabled: emancipation_category_checkbox_checked(@current_case, category)) %>
26+
2627
<div class="pt-10"><%= category.name %></div>
2728
</div>
2829
<% if category.emancipation_options.count > 0 %>
@@ -33,20 +34,20 @@
3334
<% category.emancipation_options.each do |option| %>
3435
<div class="check-item">
3536
<% if category.mutually_exclusive %>
36-
<input
37-
type="radio"
38-
id="O<%= option.id %>"
39-
class="emancipation-radio-button"
40-
name="C<%= category.id %>"
41-
value="<%= option.id %>"
42-
<%= emancipation_option_checkbox_checked(@current_case, option) %>>
37+
<%= input_tag(
38+
type: "radio",
39+
id: "O#{option.id}",
40+
class: "emancipation-radio-button",
41+
name: "C#{category.id}",
42+
value: option.id,
43+
disabled: emancipation_category_checkbox_checked(@current_case, option)) %>
4344
<% else %>
44-
<input
45-
type="checkbox"
46-
id="O<%= option.id %>"
47-
class="emancipation-option-check-box"
48-
value="<%= option.id %>"
49-
<%= emancipation_option_checkbox_checked(@current_case, option) %>>
45+
<%= input_tag(
46+
type: "checkbox",
47+
id: "O#{option.id}",
48+
class: "emancipation-option-check-box",
49+
value: option.id,
50+
disabled: emancipation_option_checkbox_checked(@current_case, option)) %>
5051
<% end %>
5152
<label><%= option.name %></label>
5253
</div>

‎app/views/imports/_cases.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
class: 'form-control mt-4',
2727
type: 'file',
2828
style: "margin: auto;" %>
29-
</div>
3029

3130
<%= button_tag id: "case-import-button", class: "main-btn primary-btn btn-hover pull-right",
3231
disabled: true, data: {disable_with: "<i class='fa fa-spinner fa-spin'></i> Importing File"} do %>
@@ -39,3 +38,4 @@
3938
})
4039
</script>
4140
<% end %>
41+
</div>

‎app/views/imports/_sms_opt_in_modal.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<span class="form-check checkbox-style">
1818
<%= form.label :sms_opt_in_label, "Opt into SMS notifications", { class: "form-check-label"} %>
1919
<%= form.check_box :sms_opt_in, { id: "sms-opt-in-checkbox", class: "form-check-input" } %>
20-
<span>
20+
</span>
2121
</div>
2222
<div class="modal-footer">
2323
<%= form.submit "Continue Import",

‎app/views/imports/_supervisors.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@
2626
class: 'form-control mt-4',
2727
type: 'file',
2828
style: "margin: auto;" %>
29-
</div>
3029

3130
<%= render "sms_opt_in_modal", { form: f } if @sms_opt_in_warning == "supervisor" %>
3231
<%= button_tag id: "supervisor-import-button", class: "main-btn primary-btn btn-hover pull-right",
3332
disabled: true, data: { disable_with: "<div class='spinner-border spinner-border-sm'></div> Importing File"} do %>
3433
<i class="lni lni-upload"></i> Import Supervisors CSV
3534
<% end %>
3635
<% end %>
36+
</div>

0 commit comments

Comments
 (0)