lint

compwron · compwron · commit 49ef446f1900 · 2026-03-07T13:09:00.000-08:00
diff --git a/.standard_todo.yml b/.standard_todo.yml
diff --git a/app/controllers/all_casa_admins/sessions_controller.rb b/app/controllers/all_casa_admins/sessions_controller.rb
@@ -2,5 +2,6 @@
 
 class AllCasaAdmins::SessionsController < Devise::SessionsController
   include Accessible
+
   skip_before_action :check_user, only: :destroy
 end
diff --git a/app/controllers/casa_cases_controller.rb b/app/controllers/casa_cases_controller.rb
@@ -184,7 +184,7 @@ def case_contact_csv_name(case_contacts)
     casa_case_number = case_contacts&.first&.casa_case&.case_number
     current_date = Time.now.strftime("%Y-%m-%d")
 
-    "#{casa_case_number.nil? ? "" : casa_case_number + "-"}case-contacts-#{current_date}.csv"
+    "#{casa_case_number + "-" unless casa_case_number.nil?}case-contacts-#{current_date}.csv"
   end
 
   def court_date_unknown?
diff --git a/app/controllers/emancipation_checklists_controller.rb b/app/controllers/emancipation_checklists_controller.rb
@@ -1,5 +1,6 @@
 class EmancipationChecklistsController < ApplicationController
   include DateHelper
+
   before_action :require_organization!
   after_action :verify_authorized
 
diff --git a/app/controllers/imports_controller.rb b/app/controllers/imports_controller.rb
@@ -2,6 +2,7 @@ class ImportsController < ApplicationController
   require "csv"
 
   include ActionView::Helpers::UrlHelper
+
   before_action :failed_csv_service, only: [:create, :download_failed]
   after_action :verify_authorized
 
diff --git a/app/controllers/users/sessions_controller.rb b/app/controllers/users/sessions_controller.rb
@@ -2,5 +2,6 @@
 
 class Users::SessionsController < Devise::SessionsController
   include Accessible
+
   skip_before_action :check_user, only: :destroy
 end
diff --git a/app/datatables/volunteer_datatable.rb b/app/datatables/volunteer_datatable.rb
@@ -166,7 +166,7 @@ def transition_aged_youth_filter
         filter = additional_filters[:transition_aged_youth]
 
         bool_filter filter do
-          "transition_aged_youth_cases.volunteer_id IS #{(filter[0] == "true") ? "NOT" : nil} NULL"
+          "transition_aged_youth_cases.volunteer_id IS #{"NOT" if filter[0] == "true"} NULL"
         end
       }.call
   end
diff --git a/app/decorators/contact_type_decorator.rb b/app/decorators/contact_type_decorator.rb
@@ -1,5 +1,6 @@
 class ContactTypeDecorator < Draper::Decorator
   include ActionView::Helpers::DateHelper
+
   delegate_all
 
   def hash_for_multi_select_with_cases(casa_case_ids)
diff --git a/app/helpers/phone_number_helper.rb b/app/helpers/phone_number_helper.rb
@@ -34,6 +34,6 @@ def valid_phone_number(number)
   end
 
   def strip_unnecessary_characters(number)
-    number.gsub(/[()\+\s\-\.]/, "")
+    number.gsub(/[()+\s\-.]/, "")
   end
 end
diff --git a/app/models/casa_org.rb b/app/models/casa_org.rb
@@ -1,5 +1,6 @@
 class CasaOrg < ApplicationRecord
   prepend ActiveSupport::ToJsonWithActiveSupportEncoder
+
   # NOTE: location of the default report template
   CASA_DEFAULT_COURT_REPORT = File.new(Rails.root.join("app/documents/templates/default_report_template.docx"), "r")
   CASA_DEFAULT_LOGO = Rails.public_path.join("logo.jpeg")
diff --git a/app/models/case_contact.rb b/app/models/case_contact.rb
@@ -1,5 +1,6 @@
 class CaseContact < ApplicationRecord
   include ByOrganizationScope
+
   acts_as_paranoid
 
   attr_accessor :duration_hours
diff --git a/app/models/concerns/api.rb b/app/models/concerns/api.rb
@@ -1,5 +1,6 @@
 module Api
   extend ActiveSupport::Concern
+
   included do
     has_one :api_credential, dependent: :destroy
     after_create :initialize_api_credentials
diff --git a/app/notifications/delivery_methods/sms.rb b/app/notifications/delivery_methods/sms.rb
@@ -1,5 +1,6 @@
 class DeliveryMethods::Sms < Noticed::DeliveryMethod
   include SmsBodyHelper
+
   def deliver
     if sender.casa_admin? || sender.supervisor?
       short_io_api = ShortUrlService.new
diff --git a/app/services/short_url_service.rb b/app/services/short_url_service.rb
@@ -6,6 +6,7 @@ class ShortUrlService
   include ApiBaseHelper
   include RequestHeaderHelper
   include HTTParty
+
   base_uri SHORT_IO
   headers ACCEPT_JSON
   headers CONTENT_TYPE_JSON
diff --git a/lib/tasks/example_recurring_task.rb b/lib/tasks/example_recurring_task.rb
@@ -1,5 +1,6 @@
 class ExampleRecurringTask
   include Delayed::RecurringJob
+
   run_every 1.day
   run_at "11:00am"
   timezone "US/Pacific"
diff --git a/spec/controllers/concerns/accessible_spec.rb b/spec/controllers/concerns/accessible_spec.rb
@@ -3,6 +3,7 @@
 class MockController < ApplicationController
   before_action :reset_session, only: :no_session_action
   include Accessible
+
   def action
     render plain: "controller action test..."
   end
diff --git a/spec/models/case_court_report_spec.rb b/spec/models/case_court_report_spec.rb
@@ -5,6 +5,7 @@
 
 RSpec.describe CaseCourtReport, type: :model do
   include DownloadHelpers
+
   let(:path_to_template) { Rails.root.join("app/documents/templates/default_report_template.docx").to_s }
   let(:path_to_report) { Rails.root.join("tmp/test_report.docx").to_s }
 
diff --git a/spec/requests/case_court_reports_spec.rb b/spec/requests/case_court_reports_spec.rb
@@ -2,6 +2,7 @@
 
 RSpec.describe "/case_court_reports", type: :request do
   include DownloadHelpers
+
   let(:volunteer) { create(:volunteer, :with_cases_and_contacts, :with_assigned_supervisor) }
 
   before do
diff --git a/spec/requests/court_dates_spec.rb b/spec/requests/court_dates_spec.rb
@@ -2,6 +2,7 @@
 
 RSpec.describe "/casa_cases/:casa_case_id/court_dates/:id", type: :request do
   include DownloadHelpers
+
   let(:admin) { create(:casa_admin) }
   let(:casa_case) { court_date.casa_case }
   let(:court_date) { create(:court_date) }
