WIP failing bad spec

Author: compwron

spec/requests/case_contacts_spec.rb

@@ -1,9 +1,11 @@
 require "rails_helper"
 # hi
 RSpec.describe "/case_contacts", type: :request do
-  let(:organization) { build(:casa_org) }
+  let(:organization) { create(:casa_org) }
   let(:admin) { create(:casa_admin, casa_org: organization) }
   let(:volunteer) { create(:volunteer, casa_org: organization) }
+  let(:supervisor) { create(:supervisor, casa_org: organization) }
+  let(:casa_case) { create(:casa_case, casa_org: organization) }
 
   before { sign_in admin }
 
@@ -14,7 +16,6 @@
       response
     end
 
-    let!(:casa_case) { create(:casa_case, casa_org: organization) }
     let!(:past_contact) { create(:case_contact, casa_case: casa_case, occurred_at: 3.weeks.ago) }
     let!(:recent_contact) { create(:case_contact, casa_case: casa_case, occurred_at: 3.days.ago) }
     let(:filterrific) { {} }
@@ -30,28 +31,47 @@
       context "with filters applied" do
         let(:filterrific) { {occurred_starting_at: 1.week.ago} }
 
-        it "returns all case contacts" do
+        it "returns filtered case contacts" do
           page = request.parsed_body.to_html
           expect(page).to include(recent_contact.creator.display_name)
           expect(page).not_to include(past_contact.creator.display_name)
         end
       end
-    end
 
+      context "with sorting" do
+        let(:filterrific) { {sorted_by: "occurred_at_desc"} }
+
+        it "returns sorted case contacts" do
+          page = request.parsed_body.to_html
+          expect(page).to include(recent_contact.creator.display_name)
+          expect(page).to include(past_contact.creator.display_name)
+        end
+      end
+    end
 
     context "when logged in as a volunteer" do
       let(:assigned_case) { create(:casa_case, :with_one_case_assignment, casa_org: organization) }
       let(:unassigned_case) { casa_case }
       let(:volunteer) { assigned_case.assigned_volunteers.first }
       let!(:assigned_case_contact) { create(:case_contact, casa_case: assigned_case, creator: volunteer) }
-      let!(:unassigned_case_contact) { create(:case_contact, casa_case: unassigned_case, creator: volunteer, duration_minutes: 180) }
+      let!(:unassigned_case_contact) { create(:case_contact, casa_case: unassigned_case, creator: volunteer) }
 
       before { sign_in volunteer }
 
       it "returns only currently assigned cases" do
         page = request.parsed_body.to_html
-        expect(page).to include("60 minutes")
-        expect(page).not_to include("3 hours")
+        binding.pry
+        expect(page).to include(assigned_case_contact.creator.display_name)
+        expect(page).not_to include(unassigned_case_contact.creator.display_name)
+      end
+    end
+
+    context "when logged in as a supervisor" do
+      before { sign_in supervisor }
+
+      it "returns all case contacts" do
+        page = request.parsed_body.to_html
+        expect(page).to include(past_contact.creator.display_name, recent_contact.creator.display_name)
       end
     end
   end
@@ -86,6 +106,15 @@
         expect(CaseContact.started.last.contact_topic_answers).to be_empty
       end
     end
+
+    context "with draft case ids" do
+      let(:draft_case_ids) { [casa_case.id] }
+
+      it "creates case contact with draft case ids" do
+        get new_case_contact_path(draft_case_ids: draft_case_ids)
+        expect(CaseContact.last.draft_case_ids).to eq(draft_case_ids)
+      end
+    end
   end
 
   describe "GET /edit" do
@@ -103,6 +132,16 @@
       request
       expect(response).to redirect_to(case_contact_form_path(:details, case_contact_id: case_contact.id))
     end
+
+    context "when user is not authorized" do
+      let(:unauthorized_volunteer) { create(:volunteer, casa_org: organization) }
+      before { sign_in unauthorized_volunteer }
+
+      it "redirects to root path" do
+        request
+        expect(response).to redirect_to(authenticated_user_root_path)
+      end
+    end
   end
 
   describe "GET /drafts" do
@@ -112,8 +151,17 @@
       response
     end
 
+    let!(:draft_contact) { create(:case_contact, status: "started") }
+    let!(:active_contact) { create(:case_contact, status: "active") }
+
     it { is_expected.to have_http_status(:success) }
 
+    it "returns only draft contacts" do
+      page = request.parsed_body.to_html
+      expect(page).to include(draft_contact.creator.display_name)
+      expect(page).not_to include(active_contact.creator.display_name)
+    end
+
     context "when user is volunteer" do
       before { sign_in volunteer }
 
@@ -140,9 +188,19 @@
     it "soft deletes the case_contact" do
       expect { request }.to change { case_contact.reload.deleted? }.from(false).to(true)
     end
+
+    context "when user is not authorized" do
+      let(:unauthorized_volunteer) { create(:volunteer, casa_org: organization) }
+      before { sign_in unauthorized_volunteer }
+
+      it "redirects to root path" do
+        request
+        expect(response).to redirect_to(authenticated_user_root_path)
+      end
+    end
   end
 
-  describe "GET /restore" do
+  describe "POST /restore" do
     subject(:request) do
       post restore_case_contact_path(case_contact), headers: {HTTP_REFERER: case_contacts_path}
 
@@ -160,9 +218,19 @@
       expect(flash[:notice]).to eq("Contact is successfully restored.")
     end
 
-    it "soft deletes the case_contact" do
+    it "restores the case_contact" do
       expect { request }.to change { case_contact.reload.deleted? }.from(true).to(false)
     end
+
+    context "when user is not authorized" do
+      let(:unauthorized_volunteer) { create(:volunteer, casa_org: organization) }
+      before { sign_in unauthorized_volunteer }
+
+      it "redirects to root path" do
+        request
+        expect(response).to redirect_to(authenticated_user_root_path)
+      end
+    end
   end
 
   xdescribe "GET /leave" do