fix prosopite config: enable raise, scope envs, clean up hooks

- Set Prosopite.raise = true so N+1s fail specs instead of silently logging
- Populate .prosopite_ignore with known-issue directories for gradual rollout
- Scope initializer to development only; spec/support/prosopite.rb owns test config
- Remove redundant prosopite settings from test.rb and production.rb
- Replace fragile FactoryBot::Strategy::Create monkey-patch with SyntaxRunner hook
- Filter comment lines in .prosopite_ignore parser

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: compwron

config/environments/production.rb

@@ -108,8 +108,4 @@
   # ]
   # Skip DNS rebinding protection for the default health check endpoint.
   # config.host_authorization = { exclude: ->(request) { request.path == "/up" } }
-
-  # Prosopite N+1 query detection (disabled by default in production)
-  config.prosopite_enabled = ENV.fetch("PROSOPITE_ENABLED", "false") == "true"
-  config.prosopite_min_n_queries = ENV.fetch("PROSOPITE_MIN_N_QUERIES", "10").to_i
 end

config/environments/test.rb

@@ -63,10 +63,6 @@
   # Raises error for missing translations.
   config.i18n.raise_on_missing_translations = true
 
-  # Prosopite N+1 query detection
-  config.prosopite_enabled = true
-  config.prosopite_min_n_queries = 2  # Stricter for tests
-
   # Annotate rendered view with file names.
   # config.action_view.annotate_rendered_view_with_filenames = true
 

config/initializers/prosopite.rb

@@ -1,21 +1,23 @@
 # frozen_string_literal: true
 
-# Only enable Rack middleware if Prosopite is configured on
-if Rails.configuration.respond_to?(:prosopite_enabled) && Rails.configuration.prosopite_enabled
+# Rack middleware for development only — in test, scanning is handled by RSpec hooks
+if Rails.env.development? &&
+    Rails.configuration.respond_to?(:prosopite_enabled) &&
+    Rails.configuration.prosopite_enabled
   require "prosopite/middleware/rack"
   Rails.configuration.middleware.use(Prosopite::Middleware::Rack)
 end
 
+# Development configuration — test config lives in spec/support/prosopite.rb
 Rails.application.config.after_initialize do
-  # Core settings
+  next unless Rails.env.development?
+
   Prosopite.enabled = Rails.configuration.respond_to?(:prosopite_enabled) &&
     Rails.configuration.prosopite_enabled
 
-  # Minimum repeated queries to trigger detection (default: 2)
   Prosopite.min_n_queries = Rails.configuration.respond_to?(:prosopite_min_n_queries) ?
                             Rails.configuration.prosopite_min_n_queries : 2
 
-  # Logging options
-  Prosopite.rails_logger = true                    # Log to Rails.logger
-  Prosopite.prosopite_logger = Rails.env.development?  # Log to log/prosopite.log
+  Prosopite.rails_logger = true
+  Prosopite.prosopite_logger = true
 end

spec/.prosopite_ignore

@@ -1,7 +1,15 @@
-# Directories to exclude from Prosopite N+1 scanning
-# Remove paths as you fix N+1s in each area
+# Directories excluded from Prosopite N+1 raise (will still log).
+# Remove paths as you fix the underlying N+1s.
 #
-# Example entries:
-# spec/features
-# spec/system
-# spec/requests/legacy
+# See PROSOPITE_TODO.md for the full list of known issues.
+spec/models
+spec/services
+spec/lib
+spec/system
+spec/requests
+spec/controllers
+spec/views
+spec/decorators
+spec/policies
+spec/datatables
+spec/helpers

spec/support/prosopite.rb

@@ -2,9 +2,9 @@
 
 return unless defined?(Prosopite)
 
-# Test configuration
+# Test configuration — this file owns all Prosopite settings for the test env
 Prosopite.enabled = true
-Prosopite.raise = false  # Log only, don't fail specs
+Prosopite.raise = true
 Prosopite.rails_logger = true
 Prosopite.prosopite_logger = true
 
@@ -16,35 +16,36 @@
   "shoulda/matchers/active_model/allow_value_matcher.rb"
 ]
 
-# Optional: Load ignore list from file for gradual rollout
+# Load ignore list from file for gradual rollout — directories listed in
+# .prosopite_ignore are scanned but won't raise, only log.
 PROSOPITE_IGNORE = if File.exist?("spec/.prosopite_ignore")
-  File.read("spec/.prosopite_ignore").lines.map(&:chomp).reject(&:empty?)
+  File.read("spec/.prosopite_ignore")
+    .lines
+    .map(&:chomp)
+    .reject { |line| line.empty? || line.start_with?("#") }
 else
   []
 end
 
-# Monkey-patch FactoryBot to pause during factory creation
-# Prevents false positives from factory callbacks
-if defined?(FactoryBot)
-  module FactoryBot
-    module Strategy
-      class Create
-        alias_method :original_result, :result
+RSpec.configure do |config|
+  # Pause Prosopite during factory creation to prevent false positives
+  # from factory callbacks and associations
+  config.before(:suite) do
+    if defined?(FactoryBot)
+      FactoryBot::SyntaxRunner.class_eval do
+        alias_method :original_create, :create
 
-        def result(evaluation)
+        def create(*args, **kwargs, &block)
           if defined?(Prosopite) && Prosopite.enabled?
-            Prosopite.pause { original_result(evaluation) }
+            Prosopite.pause { original_create(*args, **kwargs, &block) }
           else
-            original_result(evaluation)
+            original_create(*args, **kwargs, &block)
           end
         end
       end
     end
   end
-end
 
-# RSpec integration
-RSpec.configure do |config|
   config.around do |example|
     if use_prosopite?(example)
       Prosopite.scan { example.run }